Fix alpha and beta running OOM when starting the gunicorn workers #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DasSkelett
force-pushed
the
fix/worker-count
branch
from
dc36258 to
2ba0912
Compare
Makes the gunicorn worker count configurable by parsing the config.ini in spacedock-prepare.service's prepare.sh, and writing it into a systemd-readable environment file, which is the sourced in [email protected].
DasSkelett
force-pushed
the
fix/worker-count
branch
from
2ba0912 to
a6a7c96
Compare
|
Has been solved by removing the symlink from |
DasSkelett
added a commit
to DasSkelett/SpaceDock
that referenced
this pull request
May 14, 2020
`spacedock.target` is not directly used on our servers, instead an edited copy exists in `/etc/systemd/system/`. See KSP-SpaceDock#258 for more information. The `README.md` has been updated to reflect newer versions of Python and other dependencies in use. The `api.md` has also been extended a little.
HebaruSan
pushed a commit
that referenced
this pull request
Jun 3, 2020
`spacedock.target` is not directly used on our servers, instead an edited copy exists in `/etc/systemd/system/`. See #258 for more information. The `README.md` has been updated to reflect newer versions of Python and other dependencies in use. The `api.md` has also been extended a little.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently we start 6 gunicorn instances à 6 workers, which results in alpha and beta to be OOM when trying to boot up the workers, and the gunicorn processes get OOM-killed.
Since production is on a beefier machine/container, it works fine there.
Solution
This PR makes the worker count per instance configurable by reading a new property
worker-countfromconfig.iniinspacedock-prepare.sh(executed byspacedock-prepare.service, writing it in a new file which is then sourced asEnvironmentFilein the[email protected].The services use it as value to the
--workersparameter.Open for improvement suggestions.
I also removed the systemd-related remainings of SpaceDock-Notify, which is no longer needed since #246.