Don't break profile page if a mod has no default_version

[DasSkelett]

Problem

Currently, if for some, theoretically impossible, reason a mod of an author has no default_version, viewing their profile results in a 500.
(If the mod is still unpublished, it only results in a 500 for the author)

The cause of the error are the mod boxes, that are accessing mod.default_version.gameversion to display the For ... message in the corner. If mod.default_version is None, an exception is thrown.

Changes

mod-box.html checks if mod.default_version is None, and if so, displays an - instead of the KSP version.

Also the flask route is enhanced to also show unpublished mods to admins.

TODO

There are still many other places left where we are accessing mod.default_version without null-checks, for example the mod page itself.
They have to be fixed separately, which is more work.

If we want to allow mods without any releases, we'd have to do this work.
Otherwise, we could try to make the Mod.default_version_id column non-nullable. This needs a rather complex data migration to make sure there are no mods with default_version_id=None left, but I already have some code for that.

Most important, we have to find out, where Mod.default_version can be set to None currently and fix that.

[Xinayder]

I think the most important part is trying to find out what can cause a mod without a default_version field. Otherwise, we'd have to extend this null check everywhere in the code.

I have an idea to test, maybe mods without default_version are created if the upload fails.

[HebaruSan]

I think the most important part is trying to find out what can cause a mod without a default_version field.

In case anyone else has the same idea I had, you can't delete the default version:

SpaceDock/KerbalStuff/blueprints/mods.py

Lines 471 to 472 in d20ef12

	if version[0].id == mod.default_version_id:
	abort(400)

[Xinayder]

Just move the if block to hide the entire div if the mod doesn't have a default version 😄 .

[DasSkelett]

Should hide the full div now.