-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show reverse relationships #3638
Show reverse relationships #3638
Conversation
dbc6a81
to
5b82eed
Compare
fb115e2
to
4b45bdd
Compare
@tjanke42, FYI, we got some feedback that the tri-state UI was a bit confusing as-is, and I agreed, so I've changed it so the checkbox works normally unless you ctrl-click or shift-click it, in which case it goes to the special "sticky" state. |
4b45bdd
to
cc7b2f4
Compare
cc7b2f4
to
2ab9837
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really neat, constrained PR. LGTM 🎉
Damn, you guys are awesome. Based on the comments, that's a lot of work you did, HebaruSan. I appreciate it very, very much. You da man! |
Motivations
dep:identifier
search but not easily accessible.ModuleManager
)BluedogDB
)RP-0
)Changes
When unchecked, the usual relationships are shown as before. When checked, the reverse relationships are shown instead and the checkbox will revert to unchecked when you switch mods. If you shift-click or ctrl-click, it becomes checked-and-gray (the indeterminate state), the reverse relationships are shown, and the state of the checkbox is "sticky" (persists when switching mods, for when the user wants to look at reverse relationships for many mods in a row)
+
icons appear for nodes with children.ModuleInstaller.GetModuleContentsList
now returns an empty sequence instead ofnull
if it can't find any files, to make it easier forSystem.Linq
-style code to use itModuleInstaller.GetModuleContentsList
now skips directories and only returns files, because otherwise we would need to know which entries are directories and which are files, and it's really hard to do that just from strings. We don't need the directories anyway.After these changes, there is no noticeable delay when you click a row in the main mod list.
Fixes #3616.