Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Galaxies Unbound optional Clouds module #9288

Merged
merged 2 commits into from
Aug 20, 2022

Conversation

HebaruSan
Copy link
Member

There's one more module that we missed in #8515:

image

Now it's added.

@HebaruSan HebaruSan merged commit 2cee0ad into KSP-CKAN:master Aug 20, 2022
@HebaruSan HebaruSan deleted the add/GU-Clouds branch August 20, 2022 23:55
@JonnyOThan
Copy link
Contributor

Hey it looks like the recommendation for the base mod is wrong. GalaxiesUnbound-StockClouds is the identifier for the clouds module, but the base module recommends GalaxiesUnbound-Clouds

@HebaruSan

This comment was marked as resolved.

@JonnyOThan
Copy link
Contributor

Hmm, CKAN is still indicating that the clouds aren't indexed, but the names match now.
image

@HebaruSan

This comment was marked as resolved.

@JonnyOThan
Copy link
Contributor

I'm on latest ckan.

Interesting, I switched to a different game instance and now it looks correct. But swapping back to the original one still shows the broken metadata. I have everything set to auto-refresh, and a manual refresh doesn't fix it either. So it seems like something stale is getting cached somewhere.

@HebaruSan

This comment was marked as resolved.

@JonnyOThan
Copy link
Contributor

I assume you mean use one of the builds from CI? Does it matter which one?

@HebaruSan

This comment was marked as resolved.

@JonnyOThan
Copy link
Contributor

OK, it still shows it as missing by default, but if I click the "reverse relationships" button then it seems to pick it up properly.

@HebaruSan

This comment was marked as resolved.

@JonnyOThan
Copy link
Contributor

Not that I can recall but it's been a while since I did any mod management there.

Also, with reverse relationships enabled, the GU stock clouds entry indicates that it conflicts with itself.

@JonnyOThan
Copy link
Contributor

CKAN_old.zip
I renamed my CKAN directory for that instance and now it works correctly. Here's the broken one.

@HebaruSan

This comment was marked as resolved.

@HebaruSan

This comment was marked as resolved.

@HebaruSan

This comment was marked as resolved.

@HebaruSan
Copy link
Member Author

The test build should now be updated with fixes for both of those issues, if you care to re-download and try it out:
https://github.com/KSP-CKAN/CKAN/pull/3638/checks

@JonnyOThan
Copy link
Contributor

Yep, all seems well with that build. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants