use ci-linux:production base image #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using production to minimize list of changes on nightly updates: https://github.com/paritytech/polkadot/blob/master/scripts/ci/dockerfiles/polkadot/polkadot_builder.Dockerfile |
wischli
reviewed
Jun 9, 2022
Dockerfile
Outdated
| @@ -1,8 +1,7 @@ | |||
| # this container builds the kilt-parachain binary from source files and the runtime library | |||
| # pinned the version to avoid build cache invalidation | |||
|
|
|||
| # c4f0daf3-20220110 -> rust version rustc 1.58.0-nightly (46b8e7488 2021-11-07) | |||
| FROM paritytech/ci-linux:f203f298-20220421 as builder | |||
| FROM docker.io/paritytech/ci-linux:production as builder | |||
There was a problem hiding this comment.
I fear that the production image will be bumped up by Parity while we want to have full control over bumping the image to reduce error likelihood when building.
I suggest to stay with a distinct hash. The one suggested has the same digest as the current production one, e.g., they are the same.
Suggested change
| FROM docker.io/paritytech/ci-linux:production as builder | |
| FROM paritytech/ci-linux:eb1f6a26-20220518 |
There was a problem hiding this comment.
Yup, I was kinda puzzled. Since the toolchain file has precedence over the docker image, we kinda have no control.
ntn-x2
pushed a commit
that referenced
this pull request
Jun 23, 2022
* use ci-linx:production base image * Use hash tag on ci-linux to have more control than latest production Co-authored-by: William Freudenberger <[email protected]> (cherry picked from commit 4834987)
ntn-x2
added a commit
that referenced
this pull request
Jun 24, 2022
* Adds two more relaychain bootnodes for staging environment (#334) * chore: reset peregrine stg (#335) * ci: use custom ci image (#336) * Optimizes docker layer (#337) * fix: add did lookup pallet to DID authorization logic + reverse lookup index (#343) * chore: update toolchain version to nightly 1.59 (#339) * feat: proxy type for disableling deposit claiming (#341) * fix: rococo protocol id (#369) * feat: generic access control (#316) * Updates toolchain version (#345) * refactor: enforce no runtime in pallet (#349) * fix: features (#353) * feat: add tips pallet (#352) * feat: upgrade to Polkadot v0.9.19 (#357) * chore: upgrade and clean up (#360) * Adds the new rococo chainspec (#363) * feat: add launch pallet removal migration (#359) * refactor: update rilt para id from 2015 to 2108 (#364) * fix: rilt para id (#365) * feat: upgrade to Polkadot v0.9.23 (#366) * use ci-linx:production base image (#368) * feat: upgrade to Polkadot v0.9.24 (#370) * fix: fix CI builders compilation errors and pin to a specific hash (#372)
ntn-x2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO TICKET
Checklist:
array[3]useget(3), ...)