Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade and clean up #360

Merged
merged 6 commits into from
Apr 28, 2022
Merged

chore: upgrade and clean up #360

merged 6 commits into from
Apr 28, 2022

Conversation

weichweich
Copy link
Contributor

@weichweich weichweich commented Apr 28, 2022 •
edited
Loading

No Ticket

  • Use RuntimeDebug to avoid manual implementation
  • update build script for standalone
  • upgrade dependencies
  • don't disable default features for dev-dependencies
  • fix accounts for sporran chain

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@weichweich weichweich requested a review from wischli April 28, 2022 10:59
wischli
wischli approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I suppose we can assume scale {codec, info} are backwards compatible? And even if not, we would run into errors during the release pipeline testing.

pallets/did/src/did_details.rs Show resolved Hide resolved
@weichweich weichweich enabled auto-merge (squash) April 28, 2022 13:06
@weichweich weichweich merged commit 8645af1 into develop Apr 28, 2022
@weichweich weichweich deleted the aw-upgrade-clean branch April 28, 2022 14:14
ntn-x2 pushed a commit that referenced this pull request Jun 23, 2022
@weichweich @ntn-x2
chore: upgrade and clean up (#360)
5c7de24 
* chore: upgrade

* fix keys

* refactor: use runtime debug

only print when in STD environment, no need to impl ourself

* fix: don't disable default features in dev-dependencies

* refactor: remove more debug impls

(cherry picked from commit 8645af1)
ntn-x2 added a commit that referenced this pull request Jun 24, 2022
@ntn-x2
feat: release 1.7.0 (#373)
aa39f8d 
* Adds two more relaychain bootnodes for staging environment  (#334)

* chore: reset peregrine stg (#335)

* ci: use custom ci image (#336)

* Optimizes docker layer (#337)

* fix: add did lookup pallet to DID authorization logic + reverse lookup index (#343)

* chore: update toolchain version to nightly 1.59 (#339)

* feat: proxy type for disableling deposit claiming (#341)

* fix: rococo protocol id (#369)

* feat: generic access control (#316)

* Updates toolchain version (#345)

* refactor: enforce no runtime in pallet (#349)

* fix: features (#353)

* feat: add tips pallet (#352)

* feat: upgrade to Polkadot v0.9.19 (#357)

* chore: upgrade and clean up (#360)

* Adds the new rococo chainspec (#363)

* feat: add launch pallet removal migration (#359)

* refactor: update rilt para id from 2015 to 2108 (#364)

* fix: rilt para id (#365)

* feat: upgrade to Polkadot v0.9.23 (#366)

* use ci-linx:production base image (#368)

* feat: upgrade to Polkadot v0.9.24 (#370)

* fix: fix CI builders compilation errors and pin to a specific hash (#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischli wischli wischli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weichweich @wischli