Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update toolchain version to nightly 1.59 #339

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

ntn-x2
Copy link
Member

@ntn-x2 ntn-x2 commented Mar 16, 2022

Updates the toolchain version to nightly-2022-01-08, which is the latest 1.59 nightly. Apparently, support for 1.60 has been added but not yet released, so this is as far as we can go.

It works with Rust-Analyzer v0.2.975, which is the latest release. The current toolchain version breaks RA.

Also addresses some Clippy warnings after updating to 1.59.

@ntn-x2 ntn-x2 requested a review from weichweich March 16, 2022 08:45
@ntn-x2 ntn-x2 self-assigned this Mar 16, 2022
Copy link
Contributor

@weichweich weichweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ntn-x2 ntn-x2 requested a review from trusch March 16, 2022 09:21
@ntn-x2
Copy link
Member Author

ntn-x2 commented Mar 16, 2022

@trusch can you confirm this solves it for you as well?

@ntn-x2 ntn-x2 merged commit 80182c5 into develop Mar 16, 2022
@ntn-x2 ntn-x2 deleted the aa-update-toolchain-version branch March 16, 2022 12:39
ntn-x2 added a commit that referenced this pull request Mar 21, 2022
* chore: bump up toolchain to nightly 1.59

* chore: address Clippy warnings
ntn-x2 added a commit that referenced this pull request Mar 22, 2022
* chore: bump up toolchain to nightly 1.59

* chore: address Clippy warnings
ntn-x2 added a commit that referenced this pull request Mar 24, 2022
…p index (#343)

* fix: add did lookup pallet to DID authorization logic

* test: add unit tests for spiritnet and peregrine runtimes for correct DID verification key derivation

* chore: clippy

* feat: add additional map for reverse index

* test: add unit tests

* chore: update benchmarks checks

* wip: runtime upgrade scripts

* wip: lookup pallet migration

* chore: update toolchain version to nightly 1.59 (#339)

* chore: bump up toolchain to nightly 1.59

* chore: address Clippy warnings

* wip: benchmarks

* bench: benchmark compiling

* chore: try-runtime complete

* chore: update deps

* chore: add migrations to Spiritnet runtime

* chore: add comment in lookup migration

* chore: move migration into lookup pallet

* fix: add try-runtime feature to did lookup crate

* chore: fixes after rebase

* chore: fmt

* chore: ConnectedAccounts map comment

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/pallet-did-lookup/src/default_weights.rs --template=.maintain/weight-template.hbs

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

* bench: update benchmarks to include account replacement as worst case

* bench: fix InsufficientFunds error in benchmarks

* chore: fmt

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/pallet-did-lookup/src/default_weights.rs --template=.maintain/weight-template.hbs

* chore: update comments

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

Co-authored-by: kiltbot <>
ntn-x2 added a commit that referenced this pull request Mar 25, 2022
* chore: bump up toolchain to nightly 1.59

* chore: address Clippy warnings

(cherry picked from commit 80182c5)
ntn-x2 added a commit that referenced this pull request Mar 25, 2022
…p index (#343)

* fix: add did lookup pallet to DID authorization logic

* test: add unit tests for spiritnet and peregrine runtimes for correct DID verification key derivation

* chore: clippy

* feat: add additional map for reverse index

* test: add unit tests

* chore: update benchmarks checks

* wip: runtime upgrade scripts

* wip: lookup pallet migration

* chore: update toolchain version to nightly 1.59 (#339)

* chore: bump up toolchain to nightly 1.59

* chore: address Clippy warnings

* wip: benchmarks

* bench: benchmark compiling

* chore: try-runtime complete

* chore: update deps

* chore: add migrations to Spiritnet runtime

* chore: add comment in lookup migration

* chore: move migration into lookup pallet

* fix: add try-runtime feature to did lookup crate

* chore: fixes after rebase

* chore: fmt

* chore: ConnectedAccounts map comment

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/pallet-did-lookup/src/default_weights.rs --template=.maintain/weight-template.hbs

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

* bench: update benchmarks to include account replacement as worst case

* bench: fix InsufficientFunds error in benchmarks

* chore: fmt

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/pallet-did-lookup/src/default_weights.rs --template=.maintain/weight-template.hbs

* chore: update comments

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

Co-authored-by: kiltbot <>
(cherry picked from commit ff34f86)
ntn-x2 added a commit that referenced this pull request Mar 25, 2022
* Adds two more relaychain bootnodes for staging environment  (#334)

* Adds two more bootnodes for staging environment closes #1864

* Fixes staging parachain bootNodes

(cherry picked from commit 73097ff)

* ci: use caching

(cherry picked from commit aafb1a9)

* chore: reset peregrine stg (#335)

* reset peregrine stg

* delete tmp files

(cherry picked from commit f27917c)

* chore: minor peregrine-stg fix

(cherry picked from commit c2819c9)

* fix: swapped ed & sr keys

(cherry picked from commit dcb7afa)

* fix: peregrine-stg bootnodes

(cherry picked from commit 30b1cfa)

* fix: peregrine-stg parachain nodes

(cherry picked from commit 896f01a)

* fix: peregrine-stg node identity

(cherry picked from commit b84dbda)

* ci: use custom ci image (#336)

* switch to own ci image

skipping one step should speed up the build

* add ci dockerfile

* add tag

(cherry picked from commit e999bfb)

* Optimizes docker layer (#337)

* Adds copy all files in a sigle layer command

* Removes unused docker layer

* Changes debian image to ubuntu

Co-authored-by: Albrecht <[email protected]>
(cherry picked from commit 76025b1)

* chore: update toolchain version to nightly 1.59 (#339)

* chore: bump up toolchain to nightly 1.59

* chore: address Clippy warnings

(cherry picked from commit 80182c5)

* fix: add did lookup pallet to DID authorization logic + reverse lookup index (#343)

* fix: add did lookup pallet to DID authorization logic

* test: add unit tests for spiritnet and peregrine runtimes for correct DID verification key derivation

* chore: clippy

* feat: add additional map for reverse index

* test: add unit tests

* chore: update benchmarks checks

* wip: runtime upgrade scripts

* wip: lookup pallet migration

* chore: update toolchain version to nightly 1.59 (#339)

* chore: bump up toolchain to nightly 1.59

* chore: address Clippy warnings

* wip: benchmarks

* bench: benchmark compiling

* chore: try-runtime complete

* chore: update deps

* chore: add migrations to Spiritnet runtime

* chore: add comment in lookup migration

* chore: move migration into lookup pallet

* fix: add try-runtime feature to did lookup crate

* chore: fixes after rebase

* chore: fmt

* chore: ConnectedAccounts map comment

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/pallet-did-lookup/src/default_weights.rs --template=.maintain/weight-template.hbs

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

* bench: update benchmarks to include account replacement as worst case

* bench: fix InsufficientFunds error in benchmarks

* chore: fmt

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/pallet-did-lookup/src/default_weights.rs --template=.maintain/weight-template.hbs

* chore: update comments

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

Co-authored-by: kiltbot <>
(cherry picked from commit ff34f86)

* feat: proxy type for disableling deposit claiming (#341)

* proxy type for disableling deposit claiming

* fix

* fix: explicit proxy pallet logic for peregrine runtime

* fix: finalise proxy definition for spiritnet

* chore: add explicit encoding value for proxy types

* chore: update mashnet-node with similar proxy structure as peregrine

* chore: clippy

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-proxy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_proxy.rs --template=.maintain/runtime-weight-template.hbs

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-proxy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_proxy.rs --template=.maintain/runtime-weight-template.hbs

Co-authored-by: Antonio Antonino <[email protected]>
Co-authored-by: kiltbot <>
(cherry picked from commit a402710)

* fix: pallet_did_lookup weights filename

* chore: bump pallet and runtime versions

Co-authored-by: Gerawork Aynekulu <[email protected]>
Co-authored-by: weichweich <[email protected]>
ntn-x2 added a commit that referenced this pull request Jun 24, 2022
* Adds two more relaychain bootnodes for staging environment  (#334)

* chore: reset peregrine stg (#335)

* ci: use custom ci image (#336)

* Optimizes docker layer (#337)

* fix: add did lookup pallet to DID authorization logic + reverse lookup index (#343)

* chore: update toolchain version to nightly 1.59 (#339)

* feat: proxy type for disableling deposit claiming (#341)

* fix: rococo protocol id (#369)

* feat: generic access control (#316)

* Updates toolchain version (#345)

* refactor: enforce no runtime in pallet (#349)

* fix: features (#353)

* feat: add tips pallet (#352)

* feat: upgrade to Polkadot v0.9.19 (#357)

* chore: upgrade and clean up (#360)

* Adds the new rococo chainspec (#363)

* feat: add launch pallet removal migration (#359)

* refactor: update rilt para id from 2015 to 2108 (#364)

* fix: rilt para id (#365)

* feat: upgrade to Polkadot v0.9.23 (#366)

* use ci-linx:production base image (#368)

* feat: upgrade to Polkadot v0.9.24 (#370)

* fix: fix CI builders compilation errors and pin to a specific hash (#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants