tests: make tests run in CI on windows #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you can get some of the tests to run but not all, feel free to add some back to the exclusion list. Any step forward would be helpful! |
|
Yes the goal of this pr is just to make test passed that are related to missing all. I removed all the filter for now to see what is working and what is not. |
OlivierLDff
force-pushed
the
fix-msvc-dll-path
branch
16 times, most recently
from
39e27c7 to
08b463d
Compare
Be-ing
reviewed
Apr 1, 2023
|
Maybe we can revive #243 after merging this 🤔 |
OlivierLDff
force-pushed
the
fix-msvc-dll-path
branch
2 times, most recently
from
d4d46d4 to
0c13a84
Compare
|
I've force push a slight modification that also make valgrind test work with ninja multi config. So that every test can pass when using the CMakePresets.json from my other PR. |
Be-ing
reviewed
Apr 1, 2023
OlivierLDff
force-pushed
the
fix-msvc-dll-path
branch
from
0c13a84 to
83ddaf8
Compare
They were failing due to missing dll. This commit - inject the location of Qt dll in the PATH - Qt plugin directory in QT_PLUGIN_PATH - Qml import path in QML_IMPORT_PATH & QML2_IMPORT_PATH They are not necessary to every tests, but at least they should be robust for the future when more tests will be added. This commit use `ENVIRONMENT_MODIFICATION` instead of `ENVIRONMENT`, since adding a value to the PATH in windows is a mess otherwise with CMake, because `;` is used as a list separator. I took the liberty to refactor some boilerplate code, to make it working more easily. More refactoring is needed to remove boilerplate code. fixup!
…d by cmake project
Be-ing
force-pushed
the
fix-msvc-dll-path
branch
from
83ddaf8 to
620ca02
Compare
Be-ing
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were failing due to missing dll. This commit
They are not necessary to every tests, but at least they should be robust for the future when more tests will be added.
This commit use
ENVIRONMENT_MODIFICATIONinstead ofENVIRONMENT, since adding a value to the PATH in windows is a mess otherwise with CMake, because;is used as a list separator.It also move
add_subdirectoryof book and example at the end of main CMakeLists.txt file, in order not to duplicate code to setRUNTIME_ENV.Next step is to refactor all the
add_testfunction in some helper functionadd_cxxqt_testor something like that.fix #111