-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make use of cargo workspace for tests #243
Conversation
1ac9c07
to
e3b8fcf
Compare
:/ Windows is failing to link the tests...
|
That link error already exists in the main branch, but it was obscured by excluding most of the tests on Windows. |
This was implemented in another change. |
It was? What change? CMake is still calling |
Oh lol, sorry i thought this was my workspace PR which put all the examples in the same workspace :') |
This is much faster because it avoids redundant compilation.
e3b8fcf
to
1416744
Compare
I will have a look at that if you want ;) |
@OlivierLDff that would be great :) |
Superseded by #509 |
There is no need to run cargo test/clippy/fmt for each crate individually in the workspace. Reusing the workspace target directory that Corrosion uses drastically increases the speed of the tests by reusing compilation artifacts from the main build.
Depends on #229 to avoid merge conflicts