try enabling tests on Windows

[Be-ing]

Maybe #105 fixed the link errors?

[Be-ing]

Well that didn't work. I still don't know what's going wrong with those link errors.

[ahayzen-kdab]

Well that didn't work. I still don't know what's going wrong with those link errors.

Right :-/ I tried the same in a branch here earlier https://github.com/ahayzen-kdab/cxx-qt/commits/windows-exploration . I'll see if we can have someone with Windows knowledge spend some time trying to build the project locally and see if the cause can be found.

[LeonMatthesKDAB]

Just a random thought: We're in some places defining extern "C" functions that take references as arguments.

GCC has been warning about this for a while, as C doesn't have references, and we'd technically have to use pointers.
Maybe this is related somehow?

[Be-ing]

I don't see any compile warnings from GCC using GCC 11.2.1 locally on Fedora 35 nor on the Ubuntu CI.

[ahayzen-kdab]

IIRC the warnings were actually from clang and hence why we used to have this warning disable

cxx-qt/cxx-qt-gen/src/cxx_qt.cpp

Line 42 in 3828f36

#if defined(__clang__)

The Windows issues appear to be maybe linker related but it'll probably be more obvious on an actual machine than trying to fight CI, we just need to spend some time investigating what is missing/wrong.

[LeonMatthesKDAB]

Can this be closed?
We have Windows CI now, don't we?

[ahayzen-kdab]

Can this be closed? We have Windows CI now, don't we?

We don't there are problems ...

• QML tests aren't being run
• Cargo tests aren't being run
• For me the examples crash on exit but not for Be (maybe a MSVC 2019 vs 2022 thing or something has fixed it)

[Be-ing]

We still need to figure out what to do about adding Qt to PATH to fix the DLL not found errors when running the tests... or figure out some hack around #224.

[Be-ing]

However, the link errors with the tests have been fixed since overhauling the build system to compile the generated C++ with Cargo. The remaining issues are setting the required environment variables at runtime.

[ahayzen-kdab]

@Be-ing this can be closed now as there are working Windows tests? 🎉

[Be-ing]

Yes superseded by #500