Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: AWS v1.74.1 #56379

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: fbe9abb3-538b-5e4e-ba9e-bc94f4f92ebc
Repo: https://github.com/JuliaCloud/AWS.jl.git
Tree: ee0efa566d172a2a282338566d6a7167823ecb82

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
JuliaRegistrator referenced this pull request in JuliaCloud/AWS.jl Mar 10, 2022
535: Treat 'RoleArn' as an optional field when fetching ECS credentials r=mattBrzezinski a=cole-p

Port the following changes made to AWSCore.jl: JuliaCloud/AWSCore.jl#139

> The [ECS developers guide](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-iam-roles.html) implies that the `RoleArn` field should always be returned when querying the container's credential endpoint, however this isn't always the case for Amazon SageMaker jobs.
>
>Amazon avoids this in [botocore](https://github.com/boto/botocore/blob/21b06efb39da61fe4101ab9709140dc1e51dc33d/botocore/credentials.py#L1886-L1889) by not accessing the `RoleArn` field.

Co-authored-by: Cole Peters <[email protected]>
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch March 10, 2022 20:28 Inactive
@github-actions
Copy link
Contributor

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@JuliaTagBot JuliaTagBot merged commit dd468fc into master Mar 10, 2022
@JuliaTagBot JuliaTagBot deleted the registrator/aws/fbe9abb3/v1.74.1 branch March 10, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants