Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat 'RoleArn' as an optional field when fetching ECS credentials #535

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Treat 'RoleArn' as an optional field when fetching ECS credentials #535

merged 2 commits into from
Mar 10, 2022

Conversation

cole-p
Copy link
Contributor

@cole-p cole-p commented Mar 10, 2022

Port the following changes made to AWSCore.jl: JuliaCloud/AWSCore.jl#139

The ECS developers guide implies that the RoleArn field should always be returned when querying the container's credential endpoint, however this isn't always the case for Amazon SageMaker jobs.

Amazon avoids this in botocore by not accessing the RoleArn field.

mattBrzezinski
mattBrzezinski approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@mattBrzezinski mattBrzezinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 10, 2022

Build succeeded:

@bors bors bot merged commit 6080e9d into JuliaCloud:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattBrzezinski mattBrzezinski mattBrzezinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cole-p @mattBrzezinski