Treat 'RoleArn' as an optional field when fetching ECS credentials #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattBrzezinski
approved these changes
Mar 10, 2022
|
I cannot suggest the change, but in the |
Yes this should be ported no matter what |
Yes. I typed the wrong word there. This definitely should be included in |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 10, 2022
139: Treat 'RoleArn' as an optional field when fetching ECS credentials r=mattBrzezinski a=cole-p The [ECS developers guide](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-iam-roles.html) implies that the `RoleArn` field should always be returned when querying the container's credential endpoint, however this isn't always the case for Amazon SageMaker jobs. Amazon avoids this in [botocore](https://github.com/boto/botocore/blob/21b06efb39da61fe4101ab9709140dc1e51dc33d/botocore/credentials.py#L1886-L1889) by not accessing the `RoleArn` field. Co-authored-by: Cole Peters <[email protected]>
bors bot
added a commit
to JuliaCloud/AWS.jl
that referenced
this pull request
Mar 10, 2022
535: Treat 'RoleArn' as an optional field when fetching ECS credentials r=mattBrzezinski a=cole-p Port the following changes made to AWSCore.jl: JuliaCloud/AWSCore.jl#139 > The [ECS developers guide](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-iam-roles.html) implies that the `RoleArn` field should always be returned when querying the container's credential endpoint, however this isn't always the case for Amazon SageMaker jobs. > >Amazon avoids this in [botocore](https://github.com/boto/botocore/blob/21b06efb39da61fe4101ab9709140dc1e51dc33d/botocore/credentials.py#L1886-L1889) by not accessing the `RoleArn` field. Co-authored-by: Cole Peters <[email protected]>
|
CI is going to time out because it's still setup for Travis CI and not GHA. Just going to merge this manually... |
|
Timed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ECS developers guide implies that the
RoleArnfield should always be returned when querying the container's credential endpoint, however this isn't always the case for Amazon SageMaker jobs.Amazon avoids this in botocore by not accessing the
RoleArnfield.