Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrap y::UnionALL eagerly when x<:y if x isa ∀-var. #49023

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

N5N3
Copy link
Member

@N5N3 N5N3 commented Mar 16, 2023

Since we never change ∀-var's bound thus eager UnionALL unwrapping should be pretty safe.
The subtyping fix also resolves some soundness issues of intersections.
Close #45874

@N5N3 N5N3 added types and dispatch Types, subtyping and method dispatch bugfix This change fixes an existing bug labels Mar 16, 2023
@N5N3 N5N3 requested a review from vtjnash March 16, 2023 07:07
@vtjnash vtjnash merged commit c1d1bde into JuliaLang:master Mar 16, 2023
@N5N3 N5N3 deleted the UnionAll-unwrap branch March 17, 2023 01:01
oscardssmith pushed a commit to oscardssmith/julia that referenced this pull request Mar 20, 2023
Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug types and dispatch Types, subtyping and method dispatch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subtyping covariance issue with Union{<:AbstractMatrix{P},P}}
2 participants