Fix invdepth within existential subtyping. #49049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit partially reverts JuliaLang#32425.
N5N3
added
the
needs pkgeval
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. |
vtjnash
removed
the
needs pkgeval
vtjnash
approved these changes
Mar 20, 2023
There's no need to keep it.
|
MWE for S = Type{Ref{Union{Missing, Tuple{S1,S1} where S1<:T1}}} where T1
T = Type{F} where F<:(RefValue{Union{Missing, Tuple{S2,S2} where S2<:T2}} where T2)
typeintersect(S, T) #ERROR: StackOverflowError:note: This stackoverflow also happens on 1.9. |
N5N3
added a commit
to N5N3/julia
that referenced
this pull request
Mar 21, 2023
N5N3
added a commit
that referenced
this pull request
Mar 24, 2023
1. code clean for `intvalued` 2. fix stackoverflow caused by re-intersection of concrete var 3. NFC clean for #49049
Xnartharax
pushed a commit
to Xnartharax/julia
that referenced
this pull request
Apr 19, 2023
* Remove `Rinvdepth` from `stenv`
Xnartharax
pushed a commit
to Xnartharax/julia
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #49023.
Eager unwrapping changes the order of vars in env thus we must set the correct invdepth.
Fix "unreachable reached" in
CMBLensing.jlon master. (https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_date/2023-03/17/CMBLensing.primary.log)Test added.