-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subtyping covariance issue with Union{<:AbstractMatrix{P},P}} #45874
Labels
types and dispatch
Types, subtyping and method dispatch
Comments
MWE:
|
everywhere else MWE:
|
vtjnash
added
types and dispatch
Types, subtyping and method dispatch
and removed
system:windows
Affects only Windows
labels
Jul 1, 2022
vtjnash
changed the title
Unreachable reached on Windows
subtyping covariance issue with Union{<:AbstractMatrix{P},P}}
Jul 1, 2022
perhaps related or similar?
|
vtjnash
added a commit
that referenced
this issue
Jul 1, 2022
Different platforms implement qsort differently, leading to platform-specific errors. This is a quick port of the ml_matches algorithm for use instead. For small unions (almost always), this should also be slightly faster, though insignificant. Refs #45874
vtjnash
added a commit
that referenced
this issue
Jul 1, 2022
Different platforms implement qsort differently, leading to platform-specific errors. This is a quick port of the ml_matches algorithm for use instead. For small unions (almost always), this should also be slightly faster, though insignificant. Refs #45874
KristofferC
pushed a commit
that referenced
this issue
Jul 6, 2022
Different platforms implement qsort differently, leading to platform-specific errors. This is a quick port of the ml_matches algorithm for use instead. For small unions (almost always), this should also be slightly faster, though insignificant. Refs #45874
ffucci
pushed a commit
to ffucci/julia
that referenced
this issue
Aug 11, 2022
…45896) Different platforms implement qsort differently, leading to platform-specific errors. This is a quick port of the ml_matches algorithm for use instead. For small unions (almost always), this should also be slightly faster, though insignificant. Refs JuliaLang#45874
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this issue
Aug 18, 2022
…45896) Different platforms implement qsort differently, leading to platform-specific errors. This is a quick port of the ml_matches algorithm for use instead. For small unions (almost always), this should also be slightly faster, though insignificant. Refs JuliaLang#45874
N5N3
added a commit
to N5N3/julia
that referenced
this issue
Jan 31, 2023
This makes the result soundness at the cost of more subtype cost. We should try to fix this on `subtype_leftvar` side. close JuliaLang#45874.
N5N3
added a commit
to N5N3/julia
that referenced
this issue
Mar 16, 2023
N5N3
added a commit
to N5N3/julia
that referenced
this issue
Mar 16, 2023
vtjnash
pushed a commit
that referenced
this issue
Mar 16, 2023
oscardssmith
pushed a commit
to oscardssmith/julia
that referenced
this issue
Mar 20, 2023
Xnartharax
pushed a commit
to Xnartharax/julia
that referenced
this issue
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After getting a "unreachable reached", I was able to construct the following MWE that reproduces the error:
The construction of
Failure
in the last line triggers the error. Notably, only on Windows (Julia 1.7.3 x64), when running on Linux (Ubuntu WSL 1.7.3 x64), the code passes through. Of course, using the Debugger where everything is interpreted also works fine.Some observations:
Problem
, the problem vanishes. Unfortunately, the actual constructor does a bit of work, so that this is not an option.Failure
to accept aProblem
directly, without theContainer
, the problem vanishes.item
is of a more simple type - e.g., replacing the Union by eitherP
or<:AbstractMatrix{P}
- the problem vanishes.item
, a container, atypeof
-constructor call, the internal constructor like this) has been part of my code for weeks now and always worked. I did some other changes completely unrelated to this, which somehow ended up raising this error. Unfortunately, I cannot say what was responsible, since I mainly tested on WSL in the last days, where everything works.The text was updated successfully, but these errors were encountered: