Broaden signature of eigen and eigvals to AbstractMatrix to allow for Adjoint and Transpose input. #31117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for Adjoint and Transpose input. Fixes #28714
|
Thanks @andreasnoack for addressing the issue. You may also want to look at the |
fredrikekre
reviewed
Feb 20, 2019
Co-Authored-By: andreasnoack <[email protected]>
There was a problem hiding this comment.
Fixes https://github.com/JuliaLang/julia/issues/31843 too
So maybe worth testing that case?
Co-Authored-By: Nick Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is a very simple fix of JuliaLang/LinearAlgebra.jl#551. Eventually, we might be able to avoid materializing the adjoint, but the benefit will in most cases be very limited so I think we should add the simple fix right away.
Fixes JuliaLang/LinearAlgebra.jl#551