Broaden signature of eigen and eigvals to AbstractMatrix to allow for…

… Adjoint and Transpose input. (#31117) * Broaden signature of eigen and eigvals to AbstractMatrix to allow for Adjoint and Transpose input. Fixes #28714 * Update stdlib/LinearAlgebra/test/eigen.jl Co-Authored-By: andreasnoack <[email protected]> * Update stdlib/LinearAlgebra/test/eigen.jl Co-Authored-By: Nick Robinson <[email protected]>
JuliaLang · Jun 19, 2019 · 5fa469b · 5fa469b
1 parent 1e06e68
commit 5fa469b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/stdlib/LinearAlgebra/src/eigen.jl b/stdlib/LinearAlgebra/src/eigen.jl
@@ -230,7 +230,7 @@ julia> vals == F.values && vecs == F.vectors
 true
 ```
 """
-function eigen(A::StridedMatrix{T}; permute::Bool=true, scale::Bool=true, sortby::Union{Function,Nothing}=eigsortby) where T
+function eigen(A::AbstractMatrix{T}; permute::Bool=true, scale::Bool=true, sortby::Union{Function,Nothing}=eigsortby) where T
     AA = copy_oftype(A, eigtype(T))
     isdiag(AA) && return eigen(Diagonal(AA); permute=permute, scale=scale, sortby=sortby)
     return eigen!(AA; permute=permute, scale=scale, sortby=sortby)
@@ -322,7 +322,7 @@ julia> eigvals(diag_matrix)
  4.0
 ```
 """
-eigvals(A::StridedMatrix{T}; kws...) where T =
+eigvals(A::AbstractMatrix{T}; kws...) where T =
     eigvals!(copy_oftype(A, eigtype(T)); kws...)
 
 """
@@ -369,7 +369,7 @@ Stacktrace:
 [...]
 ```
 """
-function eigmax(A::Union{Number, StridedMatrix}; permute::Bool=true, scale::Bool=true)
+function eigmax(A::Union{Number, AbstractMatrix}; permute::Bool=true, scale::Bool=true)
     v = eigvals(A, permute = permute, scale = scale)
     if eltype(v)<:Complex
         throw(DomainError(A, "`A` cannot have complex eigenvalues."))

diff --git a/stdlib/LinearAlgebra/test/eigen.jl b/stdlib/LinearAlgebra/test/eigen.jl
@@ -132,4 +132,13 @@ end
     @test factstring == "$(summary(e))\neigenvalues:\n$valsstring\neigenvectors:\n$vecsstring"
 end
 
+@testset "eigen of an Adjoint" begin
+    A = randn(3,3)
+    @test eigvals(A') == eigvals(copy(A'))
+    @test eigen(A')   == eigen(copy(A'))
+    @test eigmin(A') == eigmin(copy(A'))
+    @test eigmax(A') == eigmax(copy(A'))
+end
+
+
 end # module TestEigen