-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LinearAlgebra for Julia v1.2 and v1.3 #11
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 89.4% 90.79% +1.39%
==========================================
Files 4 4
Lines 151 163 +12
==========================================
+ Hits 135 148 +13
+ Misses 16 15 -1
Continue to review full report at Codecov.
|
Can we just add |
yeah if Compat gets |
You can always make a pull request to add it... ;) |
I'd like this to be resolved before using/contributing to Compat I think the Version check here are fine for now 🤷♂ |
d8ee251
to
d225bd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eigmax
method in v1.3+ (see Broaden signature of eigen and eigvals to AbstractMatrix to allow for Adjoint and Transpose input. JuliaLang/julia#31117)