Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LinearAlgebra for Julia v1.2 and v1.3 #11

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

nickrobinson251
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jul 28, 2019

Codecov Report

Merging #11 into master will increase coverage by 1.39%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage    89.4%   90.79%   +1.39%     
==========================================
  Files           4        4              
  Lines         151      163      +12     
==========================================
+ Hits          135      148      +13     
+ Misses         16       15       -1
Impacted Files Coverage Δ
src/linalg.jl 97.36% <85.71%> (+0.14%) ⬆️
src/blockdiagonal.jl 78.84% <0%> (+7.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd4c064...5a45178. Read the comment docs.

@rofinn
Copy link
Contributor

rofinn commented Jul 28, 2019

Can we just add eigsort! and eigmax to Compat.jl?

@nickrobinson251
Copy link
Contributor Author

nickrobinson251 commented Jul 28, 2019

Can we just add eigsort! and eigmax to Compat.jl?

yeah if Compat gets eigsort! then we can consider using Compat here

@rofinn
Copy link
Contributor

rofinn commented Jul 28, 2019

You can always make a pull request to add it... ;)

@nickrobinson251
Copy link
Contributor Author

I'd like this to be resolved before using/contributing to Compat
JuliaLang/Compat.jl#651

I think the Version check here are fine for now 🤷‍♂

src/linalg.jl Outdated Show resolved Hide resolved
@rofinn rofinn self-requested a review July 29, 2019 22:13
Copy link
Contributor

@rofinn rofinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickrobinson251 nickrobinson251 merged commit f374931 into master Jul 29, 2019
@nickrobinson251 nickrobinson251 deleted the npr/newer-julia branch July 30, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants