Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove K"parens" from SyntaxNode #269

Merged
merged 1 commit into from
May 7, 2023
Merged

Conversation

c42f
Copy link
Member

@c42f c42f commented May 7, 2023

Another approach to fix #239.

Elide all K"parens" nodes from the SyntaxNode tree, replacing them with their single child.

With #268 merged, this approach works more neatly and doesn't have the downsides of #265.

Close #265

Another approach to fix #239.

Elide all `K"parens"` nodes from the `SyntaxNode` tree, replacing them
with their single child.

With #268 merged, this approach works more neatly and doesn't have the
downsides of #265.
@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #269 (0673eaa) into main (5bb321a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
+ Coverage   96.54%   96.57%   +0.02%     
==========================================
  Files          15       15              
  Lines        3993     3997       +4     
==========================================
+ Hits         3855     3860       +5     
+ Misses        138      137       -1     
Impacted Files Coverage Δ
src/parser_api.jl 88.40% <100.00%> (ø)
src/syntax_tree.jl 95.10% <100.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

@c42f c42f merged commit 3bd6dff into main May 7, 2023
@c42f c42f deleted the c42f/parens-not-in-syntax-node-3 branch May 7, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide whether K"parens" should be visible to SyntaxNode
1 participant