Construct Expr directly from ParseStream #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 96.41% 96.54% +0.12%
==========================================
Files 15 15
Lines 3933 3993 +60
==========================================
+ Hits 3792 3855 +63
+ Misses 141 138 -3
|
c42f
force-pushed
the
c42f/tree-building
branch
2 times, most recently
from
90f27ab to
9ebf92d
Compare
Generalize `build_tree` so that we can more easily construct tree types other than `GreenNode`. Use this to construct `Expr` directly from `ParseStream` rather than constructing both GreenNode and SyntaxNode along the way. Fix a bunch of type instabilities in the `Expr` conversion code along the way. With these changes, parsing all of Base to `Expr` is sped up by about 35% overall and allocations reduced by around 50%. (Parsing to `Expr` is now comparable with parsing to `SyntaxNode`.)
c42f
added a commit
that referenced
this pull request
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize
build_treeso that we can more easily construct tree types other thanGreenNode. Use this to constructExprdirectly fromParseStreamrather than constructing both GreenNode and SyntaxNode along the way.Fix a bunch of type instabilities in the
Exprconversion code along the way.With these changes, parsing all of Base to
Expris sped up by about 35% overall and allocations reduced by around 50%. (Parsing toExpris now comparable with parsing toSyntaxNode.)