Remove K"parens" from SyntaxNode
#265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible fix for #239: * Add a `head` field to `SyntaxNode` to separate it from `GreenNode` * When a `K"parens"` node is encountered in the green tree, replace it with its child. * However, have the replacement point to the parens `GreenNode` so we can still observe parentheses This turns out to work, but is awkward. It's especially awkward/surprising for `sourcetext`, as we have things like ```julia julia> kind(parsestmt(SyntaxNode, "(10)")) K"Integer" julia> sourcetext(parsestmt(SyntaxNode, "(10)")) "(10)" ``` We could fix `sourcetext()` to avoid this inconsistency at the cost of traversing the raw tree dynamically. But then do we also need to change `range()`?
c42f
added a commit
that referenced
this pull request
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One approach to fix #239:
headfield toSyntaxNodeto separate it fromGreenNodeK"parens"node is encountered in the green tree, replace it with its child.GreenNodeso we can still observe parenthesesThis turns out to work, but is awkward. It's especially awkward/surprising for
sourcetext, as we have things likeWe could fix
sourcetext()to avoid this inconsistency at the cost of traversing the raw tree dynamically. But then do we also need to changerange()?Overall this approach is not feeling great to me.