-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort
for NTuple and other iterables
#804
Conversation
sort
for NTuple and iterablessort
for NTuple and other iterables
Codecov Report
@@ Coverage Diff @@
## master #804 +/- ##
==========================================
- Coverage 92.54% 92.42% -0.12%
==========================================
Files 2 2
Lines 295 317 +22
==========================================
+ Hits 273 293 +20
- Misses 22 24 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for some minor nit regarding import
usage.
I improved the use of I also switched over to that style for code I introduced in #799 for overloading
sort(v::AbstractVector; kws...) = sort!(copymutable(v); kws...)
|
Co-authored-by: Martin Holters <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks.
This should probably be reverted as it was reverted upstream: JuliaLang/julia#52010 |
We probably need to deprecate this here instead of reverting completely. |
Closes #803.