Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support round/trunc/ceil/floor for Bool #799

Merged
merged 7 commits into from
Jun 23, 2023

Conversation

mtfishman
Copy link
Contributor

Closes #798.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #799 (920202a) into master (16043df) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
- Coverage   91.92%   91.69%   -0.23%     
==========================================
  Files           2        2              
  Lines         260      265       +5     
==========================================
+ Hits          239      243       +4     
- Misses         21       22       +1     
Impacted Files Coverage Δ
src/Compat.jl 92.21% <100.00%> (-0.26%) ⬇️

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm, but needs an entry in the README. Also feel free to bump the version in Project.toml for an immediate release.

src/Compat.jl Outdated Show resolved Hide resolved
@mtfishman
Copy link
Contributor Author

@martinholters I added an entry to the README and bumped the version, good from my end.

@martinholters martinholters merged commit 70ab162 into JuliaLang:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support round/trunc/ceil/floor for Bool
2 participants