Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Compat dependency and references to Pkg.dir #784

Closed
wants to merge 4 commits into from
Closed

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Aug 9, 2018

Also require 0.7

The diff is big

@ararslan
Copy link
Member Author

ararslan commented Aug 9, 2018

FYI this is needed fairly urgently to get 1.0 docs for Julia itself

@ararslan
Copy link
Member Author

ararslan commented Aug 9, 2018

Actually only a small bit of this is required in order to deploy documentation, and we're doing that locally to get 1.0 docs. This will be needed for packages on 0.7/1.0 though.

@mortenpi mortenpi added this to the 0.20.0 milestone Aug 9, 2018
@mortenpi
Copy link
Member

mortenpi commented Aug 9, 2018

Ok, this is a bit of a surprise. I somehow assumed that a 0.6-Compatted package would just work on 1.0. I'll merge and tag #782, and then we can deal with this next.

@fredrikekre
Copy link
Member

@mortenpi it's chill, I built docs locally and pushed to gh pages for now so there is no rush.

@mortenpi
Copy link
Member

This is not actually necessary for 0.7/1.0 deployments, right? Documenter should actually be working fine on 1.0 at the moment.

Pkg.dir does need to be fixed, but that only affects Travis.genkeys and generate, neither of which are important for doc builds.

@ararslan
Copy link
Member Author

Documenter should actually be working fine on 1.0 at the moment.

Not for deployment, which is how we noticed that the package needed to be updated, and as you said, generation and Travis stuff.

@mortenpi
Copy link
Member

The deprecation that failed the deployment was fixed in v0.19.3, but unfortunately Documenter hadn't been updated in Base. Ref: JuliaLang/julia#28559

@fredrikekre
Copy link
Member

#795

@fredrikekre fredrikekre deleted the aa/1.0 branch August 15, 2018 06:56
@mortenpi mortenpi removed this from the 0.20.0 milestone Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants