-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Compat dependency and references to Pkg.dir #784
Conversation
FYI this is needed fairly urgently to get 1.0 docs for Julia itself |
Actually only a small bit of this is required in order to deploy documentation, and we're doing that locally to get 1.0 docs. This will be needed for packages on 0.7/1.0 though. |
Ok, this is a bit of a surprise. I somehow assumed that a 0.6-Compatted package would just work on 1.0. I'll merge and tag #782, and then we can deal with this next. |
@mortenpi it's chill, I built docs locally and pushed to gh pages for now so there is no rush. |
This is not actually necessary for 0.7/1.0 deployments, right? Documenter should actually be working fine on 1.0 at the moment.
|
Not for deployment, which is how we noticed that the package needed to be updated, and as you said, generation and Travis stuff. |
The deprecation that failed the deployment was fixed in v0.19.3, but unfortunately Documenter hadn't been updated in Base. Ref: JuliaLang/julia#28559 |
Also require 0.7
The diff is big