Bump Julia require to 0.7, stop testing on 0.6. #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
approved these changes
Aug 14, 2018
README.md
Outdated
|
|
||
| Support for Julia `0.4` and `0.5` has been dropped in the latest version, but older versions of Documenter may still work with those Julia versions (the `0.8` and `0.11` branches for either Julia version, respectively). | ||
| Support for Julia `0.4`, `0.5` and `0.6` has been dropped in the latest version, but older versions of Documenter may still work with those Julia versions (the `0.8` and `0.11` branches for either Julia version, respectively). |
There was a problem hiding this comment.
Should mentioned 0.19 for 0.6.
|
Yeah, I think we should drop 0.6 before we do any other substantial changes. But also remove compat stuff, right? Should we apply FemtoCleaner here? |
This was referenced Aug 15, 2018
Closed
mortenpi
approved these changes
Aug 15, 2018
ararslan
reviewed
Aug 15, 2018
| @@ -76,7 +75,7 @@ meta(m) = Docs.meta(m) | |||
| nameof(x::Function) = typeof(x).name.mt.name | |||
| nameof(b::Base.Docs.Binding) = b.var | |||
| nameof(x::DataType) = x.name.name | |||
| nameof(m::Module) = Compat.nameof(m) | |||
| nameof(m::Module) = nameof(m) | |||
There was a problem hiding this comment.
Won't this stack overflow? As of 0.7 this local nameof definition should be able to be removed entirely, since it's in Base. (Though we might still need to add a definition like Base.nameof(b::Base.Docs.Binding) = b.var.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it might be easier to first get this in, then clean up after, since there will be quite a lot of changes for the next Documenter release. Thoughts?
I also removed PackageEval results from README. We can add it back when that actually works.