-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tcp layers tutorial #414
Tcp layers tutorial #414
Conversation
I added the gifs and most of the code blocks to the tutorial though some of the gifs still need tweaking.
tutorial 8 in beginners start here page add tutorial_8 to make.jl
Codecov Report
@@ Coverage Diff @@
## tcp-layers-tutorial #414 +/- ##
====================================================
Coverage 96.25% 96.25%
====================================================
Files 35 35
Lines 1521 1521
====================================================
Hits 1464 1464
Misses 57 57 Continue to review full report at Codecov.
|
Thanks @gpucce We're currently working through it on Twitch 😉 |
Just a suggestion. Can we have convenience methods rather than the anonymous functions ? |
sure, you mean the one inside the dancing_circles functions? |
Will do later today |
PR Checklist
If you are contributing to
Javis.jl
, please make sure you are able to check off each item on this list:CHANGELOG.md
with whatever changes/features I added with this PR?Project.toml
+ set an upper bound of the dependency (if applicable)?test
directory (if applicable)?Link to relevant issue(s)
Closes #379
How did you address these issues with this PR? What methods did you use?
I followed the outline as closely as I understood it