Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tcp layers tutorial #414

Merged

Conversation

gpucce
Copy link
Member

@gpucce gpucce commented Sep 12, 2021

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #379

How did you address these issues with this PR? What methods did you use?
I followed the outline as closely as I understood it

@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #414 (95ae767) into tcp-layers-tutorial (c7c7a9d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           tcp-layers-tutorial     #414   +/-   ##
====================================================
  Coverage                96.25%   96.25%           
====================================================
  Files                       35       35           
  Lines                     1521     1521           
====================================================
  Hits                      1464     1464           
  Misses                      57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c7a9d...95ae767. Read the comment docs.

@Wikunia
Copy link
Member

Wikunia commented Sep 12, 2021

Thanks @gpucce We're currently working through it on Twitch 😉
https://www.twitch.tv/thecedarprince

@Wikunia Wikunia linked an issue Sep 12, 2021 that may be closed by this pull request
@Sov-trotter
Copy link
Member

Just a suggestion. Can we have convenience methods rather than the anonymous functions ?

@gpucce
Copy link
Member Author

gpucce commented Sep 12, 2021

sure, you mean the one inside the dancing_circles functions?

@gpucce
Copy link
Member Author

gpucce commented Sep 12, 2021

Will do later today

@TheCedarPrince TheCedarPrince merged commit 95ae767 into JuliaAnimators:tcp-layers-tutorial Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layers Tutorial
4 participants