Bug fixes #55
Merged
Bug fixes #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: bump to sphinx4 to avoid dependency error build: bump to poetry1.1 .gitignore: add some directories and files
Resolves JoFrhwld#52 by adding extractFormants.py and FAAValign.py as systemwide commands when the package is installed by pip. The imports still won't work when run directly from the directory rather than the established entry point.
Resolves JoFrhwld#53 by adding the applications directory to the path before searching for Praat.
Update .gitignore and documentation metadata as well.
When 2.0.0 was released, the dist folder had old development versions rather than the release version which introduced old bugs if installed via pip. This bug fix distributes the correct binaries.
fave.align.transcriptprocessor.TranscriptProcessor was mis-spelled in previous versions which caused problems as the file name and class name did not match.
When running the aligner, the logger checks for any changes in the repo and prints the differences to the log. If there's no repo then the error output gets printed to the terminal which can be confusing for users. This commit first checks to see if a git repo exists, and skips the process if not.
|
The build failure is fixed in another commit not included here, see: chrisbrickhouse@fa9520a Edit: I've included it and some other fixes as well |
added 4 commits
July 12, 2022 12:59
Using github actions, check that submitted code has no syntax errors and passes all tests. The code is tested on pythons 3.8, 3.9, and 3.10 and on the latest ubuntu, macos, and windows releases (among others). Squashed commit of the following: commit 46a7c9b Author: Christian Brickhouse <[email protected]> Date: Tue Jul 12 14:22:32 2022 -0700 Make workflow names more intuitive commit e168e20 Author: Christian Brickhouse <[email protected]> Date: Tue Jul 12 14:17:54 2022 -0700 Remove bash conditional that caused windows runs to fail. commit 8b0c587 Author: Christian Brickhouse <[email protected]> Date: Tue Jul 12 14:11:40 2022 -0700 Fix yml error commit e0520fe Author: Christian Brickhouse <[email protected]> Date: Tue Jul 12 14:10:27 2022 -0700 Add additional OS tests. commit 255bd1b Author: Christian Brickhouse <[email protected]> Date: Tue Jul 12 14:04:08 2022 -0700 Configure pytest so it finds the fave module. commit fa11b96 Merge: cac8c3e 6adfde3 Author: Christian Brickhouse <[email protected]> Date: Tue Jul 12 14:01:33 2022 -0700 Merge branch 'workflows' of github.com:chrisbrickhouse/FAVE into workflows commit cac8c3e Author: Christian Brickhouse <[email protected]> Date: Tue Jul 12 13:58:33 2022 -0700 Add flake8 config commit 06f6121 Author: Christian Brickhouse <[email protected]> Date: Tue Jul 12 13:41:59 2022 -0700 Set to run on this branch commit ffb7328 Author: Christian Brickhouse <[email protected]> Date: Mon Jul 11 18:16:15 2022 -0700 Add basic tests for TranscriptProcessor commit 356867d Author: Christian Brickhouse <[email protected]> Date: Mon Jul 11 16:38:33 2022 -0700 Add basic python package CI workflow commit 6adfde3 Author: Christian Brickhouse <[email protected]> Date: Tue Jul 12 13:41:59 2022 -0700 Set to run on this branch commit 77be18d Author: Christian Brickhouse <[email protected]> Date: Mon Jul 11 18:16:15 2022 -0700 Add basic tests for TranscriptProcessor commit 348963d Author: Christian Brickhouse <[email protected]> Date: Mon Jul 11 16:38:33 2022 -0700 Add basic python package CI workflow
|
The new jobs aren't set up to run on this branch, but you can see them pass when run in the workflows development branch: https://github.com/chrisbrickhouse/FAVE/actions/runs/2659481671 This PR should be ready for review and merging |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/distgit diffoutput unless in a git repo