Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac OSX doesn't guarantee praat in PATH #53

Closed
chrisbrickhouse opened this issue May 6, 2022 · 0 comments · Fixed by #55
Closed

Mac OSX doesn't guarantee praat in PATH #53

chrisbrickhouse opened this issue May 6, 2022 · 0 comments · Fixed by #55

Comments

@chrisbrickhouse
Copy link
Collaborator

Troubleshooting use of fave/extractFormants.py on a fresh install of Fave2.0.0 and we ran into the problem of praat not being in PATH. The program was installed, but it seems to live in the Applications directory which is not normally in PATH. This means that the search on line 2090 fails, and the user (who has praat installed) is left with a confusing message about how the program cannot be found.

The workaround we found was to edit the user's ~/.bash_profile so that the applications directory is added to their PATH when starting their terminal session. I'd argue this is not ideal. Adding the whole applications folder to their PATH introduces a vulnerability, and adding the specific Praat folder to their PATH is fragile should praat ever change its directory structure or install location. It's probably also not the best idea to encourage end users to play around in their bash profile. This all goes double for asking them to symlink to praat from their /usr/local/bin

The best solution, I think, is a more intelligent search for praat. If the search fails (line 2097) it would make sense to search for an ~/Applications directory and see if we can find a praat executable in there (probably with a warning in case it's old or broken). If so, use it, and if not fail with some additional information. Thoughts?

chrisbrickhouse added a commit to chrisbrickhouse/FAVE that referenced this issue May 25, 2022
Resolves JoFrhwld#53 by adding the applications directory
to the path before searching for Praat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant