Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extractFormants module imports don't work out-of-the-box #52

Closed
chrisbrickhouse opened this issue May 6, 2022 · 0 comments
Closed

extractFormants module imports don't work out-of-the-box #52

chrisbrickhouse opened this issue May 6, 2022 · 0 comments

Comments

@chrisbrickhouse
Copy link
Collaborator

Was troubleshooting fave/extractFormants.py on a fresh install of Fave2.0.0 and found an issue with the import fave instructions. If the module is installed via pip (or pip -e) then this import should function fine. If users are running it as a script from a downloaded repo (like they would in Fave1.X), the script fails with a ModuleImportError because it is inside the fave directory and cannot find the module locally.

The workaround we found is to move ./fave/extractFormants.py up the tree to ./extractFormants.py so that that the relative import works. I'm not sure this is a viable solution in terms of packaging though. An alternative might be to change it to a relative import using import ., or modifying the script to fail gracefully and fall back on a relative import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant