Accessibility stage 1 #1025
Merged
Accessibility stage 1 #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima-avdeev-jb
approved these changes
Jan 31, 2024
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2022 The Android Open Source Project | |||
| * Copyright 2023 The Android Open Source Project | |||
There was a problem hiding this comment.
No, @MatkovIvan said that Google stated that those indicate the file creation date and not the current one
| @@ -158,8 +185,37 @@ private class AccessibilityElement( | |||
| return null | |||
| } | |||
|
|
|||
| // TODO: remove if unneeded | |||
There was a problem hiding this comment.
No, this one slipped from me, removed.
Comment on lines
+339
to
+340
| 0F, | ||
| -height.toFloat() * dimensionScale |
There was a problem hiding this comment.
can we add argument names here? Or it is Function type without named arguments?
There was a problem hiding this comment.
Yes, it's (x: Float, y: Float) -> Boolean, IDE can recognise the labels, but named arguments are not allowed for function types indeed.
ASalavei
requested changes
Feb 2, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/Accessibility.uikit.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/Accessibility.uikit.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/Accessibility.uikit.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/Accessibility.uikit.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt
Outdated
Show resolved
Hide resolved
ASalavei
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
MVP for UIAccessibility integration on iOS
Testing
Test: TODO
API changes
Added to iOS source set: