Compose iOS accessibility support #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
A couple of ideas regarding the structure:
- Consistent headers, noun-phrases "Accessibility tree synchronization/ Accessibility APIs" or verbs "Customize accessibility tree synchronization/ Adjust accessibility behavior with APIs"
- Instead of the Accessibility APIs reference section, make two use cases: Customize accessibility tree synchronization (includes AccessibilitySyncOptions description) and Set up logging (includes AccessibilityDebugLogger description)
| to native accessibility properties such as `accessibilityIdentifier`. This makes semantic data from Compose Multiplatform available | ||
| to Accessibility Services and XCTest framework. | ||
|
|
||
| Notable limitations of the current accessibility support: |
There was a problem hiding this comment.
I think here you can move the repetitive part to the list's intro:
The Compose accessibility API doesn't currently cover(support):
- Live regions, announcements about..
- UIKit elements inside Compose Multiplatform UI.
| By default, the iOS accessibility tree is synchronized with the UI only when Accessibility Services are running; | ||
| by default, no accessibility logs are written. | ||
| You can customize this behavior, for example, when you want to debug events and interactions: | ||
| activate the option to always synchronize the accessibility tree, so that the tree is rewritten every time the UI updates. |
There was a problem hiding this comment.
The sentence is quite long, maybe split it after the colon?
| You can customize this behavior, for example, when you want to debug events and interactions: | ||
| activate the option to always synchronize the accessibility tree, so that the tree is rewritten every time the UI updates. | ||
|
|
||
| > Always synchronizing the tree can be quite useful for debugging and testing, but be aware that there is a significant |
There was a problem hiding this comment.
A part of the second sentence repeats the section's intro, I think we can safely shorten this tip to:
Constant synchronizing (or Constant synchronization of) the tree can be quite useful for debugging and testing but can degrade your app's performance.
Also, it look likes rather important, maybe turn it into a note?
Co-authored-by: Danil Pavlov <[email protected]>
# Conflicts: # mpd.tree
danil-pavlov
approved these changes
Feb 28, 2024
Co-authored-by: Danil Pavlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JetBrains/compose-multiplatform-core#1025