Code

Accessibility stage 1#1025

Code

Merged

elijah-semyonov merged 65 commits intojb-mainJetBrains/compose-multiplatform-core:jb-mainfrom es/accessibility-stage-1JetBrains/compose-multiplatform-core:es/accessibility-stage-1Copy head branch name to clipboardFeb 2, 2024

+704-305

Commits

Commits on Jan 26, 2024

• Update copyright, add CMPAccessibilityScrollView

  elijah-semyonov

  committed
  c1d2962

• Rewire ScrollView accessibility implementation

  elijah-semyonov

  committed
  0a150aa

• Avoid edge case where impl could be changed after the object is logically dead

  elijah-semyonov

  committed
  9c32cb8

• Add scrolling logic stubs

  elijah-semyonov

  committed
  1125119

• Add @ExportoOjc for name resolution in debugger

  elijah-semyonov

  committed
  6c6cf0a

• Print debug data on focus

  elijah-semyonov

  committed
  3729153

• Fix crash

  elijah-semyonov

  committed
  49e669b

• Add logic for scrolling.

  elijah-semyonov

  committed
  1164c62

• Add TODOs

  elijah-semyonov

  committed
  868d512

• Add TODO

  elijah-semyonov

  committed
  5b12a6d

• Fix

  elijah-semyonov

  committed
  1fcef2a

• Add TODOs, remove dead code

  elijah-semyonov

  committed
  e5de324

• Add testTag and recursive scroll call

  elijah-semyonov

  committed
  8959b17

• Fix scrolling

  elijah-semyonov

  committed
  e8b601e

• Remove indirect implementation.

  elijah-semyonov

  committed
  599e68c

• Add EditableText to label

  elijah-semyonov

  committed
  7dcf650

• Add more debug logs.

  elijah-semyonov

  committed
  e572daf

• Add more debug logs.

  elijah-semyonov

  committed
  9d89068

• Post layout change notification when synced something.

  elijah-semyonov

  committed
  0f40513

• Add todo for crash.

  elijah-semyonov

  committed
  364a0df

• Minor changes

  elijah-semyonov

  committed
  d257c17

• Enrich logging

  elijah-semyonov

  committed
  937ecaf

• Add scroll to visible element on focus change

  elijah-semyonov

  committed
  712a7b6

• Add arbitary scale to avoid overscrolling

  elijah-semyonov

  committed
  a90575f

• Fix scrollTo logic a bit

  elijah-semyonov

  committed
  0c6f2c1

• Fix scrollTo logic a bit

  elijah-semyonov

  committed
  9312951

• Add TODO

  elijah-semyonov

  committed
  f651d43

• Add TODO

  elijah-semyonov

  committed
  47ece12

• Avoid creating a new semantics node every time its id is asked

  elijah-semyonov

  committed
  2dea87e

• Add possibility to refocus a11y from dead elements

  elijah-semyonov

  committed
  768448c

• Eagerly recompute semantics tree on render

  elijah-semyonov

  committed
  afd3d83

• Revert "Eagerly recompute semantics tree on render"

  Show description for b617f2e
  elijah-semyonov

  committed
  b617f2e

• Cherry pick minor refactoring from reverted commit

  elijah-semyonov

  committed
  e16af45

• Revert "Prevent unattached nodes from making it into the semantics tree"

  Show description for cc89a29
  elijah-semyonov

  committed
  cc89a29

• Remove unrelevant todo

  elijah-semyonov

  committed
  3dc016d

• Add config option to force accessibility sync

  elijah-semyonov

  committed
  a7e4eed

• Integrate new strategy with some debug prints.

  elijah-semyonov

  committed
  81faf63

• Add debug log

  elijah-semyonov

  committed
  a763f9c

• Remove ghost semantic nodes.

  elijah-semyonov

  committed
  a8f9f8c

• Comment out error for now

  elijah-semyonov

  committed
  1c1a707

• Fix compilation error and accessibilityActivate crash

  elijah-semyonov

  committed
  0b3b0f1

• Resolve label on the fly

  elijah-semyonov

  committed
  9f5dc1f

• Resolve isAccessible dynamically

  elijah-semyonov

  committed
  d8ddae7

• Modify isAccessibilityElement logic

  elijah-semyonov

  committed
  44bb9b7

• Ignore IsTraversalGroup for accessibility focus

  elijah-semyonov

  committed
  bd63d31

• Modify accessibility logic

  elijah-semyonov

  committed
  4a50229

• Compute UITraits lazily

  elijah-semyonov

  committed
  fbc81f9

• Modify label computation logic

  elijah-semyonov

  committed
  8b4a809

• Move more computed properties to lazy

  elijah-semyonov

  committed
  9b70ebb

• Make all a11y properties computed

  elijah-semyonov

  committed
  b056e08

• Add todo

  elijah-semyonov

  committed
  0c57f01

Commits on Jan 30, 2024

• Update API

  elijah-semyonov

  committed
  88c9217

• Fix unconditional log

  elijah-semyonov

  committed
  c1985a7

• Mark experimental API

  elijah-semyonov

  committed
  8013201

• OptIn and remove feature flag.

  elijah-semyonov

  committed
  8634379

• Fix invalid cardinality

  elijah-semyonov

  committed
  f6409e6

• Revert cherrypick

  elijah-semyonov

  committed
  2c511c1

Commits on Jan 31, 2024

• Merge branch 'jb-main' into es/accessibility-stage-1

  elijah-semyonov

  authored
  99274b8

• Remove redundant TODO

  elijah-semyonov

  committed
  e8cc3c3

• Merge branch 'jb-main' into es/accessibility-stage-1

  elijah-semyonov

  authored
  87da0d3

Commits on Feb 2, 2024

• Remove extra return.

  elijah-semyonov

  committed
  592cd1e

• Add review-based changes

  elijah-semyonov

  committed
  816c358

• Remove println

  elijah-semyonov

  committed
  6a9f2e7

• Add debug logger to demo app

  elijah-semyonov

  committed
  caca45a

• Fix scrolling bug

  elijah-semyonov

  committed
  0efb15d