Move groups field from others to general #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
Siedlerchr
approved these changes
Nov 6, 2017
| @@ -24,19 +24,6 @@ public OtherFieldsTab(BibDatabaseContext databaseContext, SuggestionProviders su | |||
| setGraphic(IconTheme.JabRefIcon.OPTIONAL.getGraphicNode()); | |||
| } | |||
|
|
|||
| public static boolean isOtherField(EntryType entryType, String fieldToCheck) { | |||
There was a problem hiding this comment.
Any reason why you deleted this?
Otherwise lgtm
There was a problem hiding this comment.
Yes, the code was no longer used.
|
Finally, the entry editor is again functional and performing well enough to take care about a better structuring of the displayed fields :) The PR is good to go. Actually the build failure comes from a broken PR merged into master that is already fixed. I am merging directly. |
Siedlerchr
added a commit
that referenced
this pull request
Nov 10, 2017
* upstream/master: (26 commits) Fix test for quoted lang messages (#3424) Update gradle from 4.3 to 4.3.1 Fix #3411: ordering of fields in customized entry types works again (#3422) Backport of syncLang to python2 (#3420) Remove Versioneye badge Fix some error prone warnings Fix for issue #2721 append to a field (#3395) Fix travis - hopefully Remove 3.x changelog (#3250) Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library Try to enable LGTM Update guava from 23.2 -> 23.3 (#3409) Update wiremock from 2.8.0 -> 2.10.1 Move groups field from others to general (#3407) Fix checkstyle issues to repair build Fix #3046: No longer allow duplicate fields in customized entry types (#3405) Strip invalid prolog when loading CitationStyles (#3404) Integrity check "Abbreviation Detection" detects abbreviated names for journals and booktitles based on the internal list instead of only looking for "." signs. (#3362) Update gradle from 4.2.1 to 4.3 Update gradle from 4.2.1 to 4.3 ...
Siedlerchr
added a commit
that referenced
this pull request
Nov 18, 2017
* upstream/master: (23 commits) Feature java version check again (#3428) Fix test for quoted lang messages (#3424) Update gradle from 4.3 to 4.3.1 Fix #3411: ordering of fields in customized entry types works again (#3422) Backport of syncLang to python2 (#3420) Remove Versioneye badge Fix some error prone warnings Fix for issue #2721 append to a field (#3395) Fix travis - hopefully Remove 3.x changelog (#3250) Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library Try to enable LGTM Update guava from 23.2 -> 23.3 (#3409) Update wiremock from 2.8.0 -> 2.10.1 Move groups field from others to general (#3407) Fix checkstyle issues to repair build Fix #3046: No longer allow duplicate fields in customized entry types (#3405) Strip invalid prolog when loading CitationStyles (#3404) Integrity check "Abbreviation Detection" detects abbreviated names for journals and booktitles based on the internal list instead of only looking for "." signs. (#3362) Update gradle from 4.2.1 to 4.3 ...
Siedlerchr
added a commit
that referenced
this pull request
Nov 19, 2017
* upstream/master: (30 commits) Add Hint for checking master version (#3439) Replace LinkedFiles backslashes with forward slashes (#3403) fix isbn result from chimbori (#3442) Feature java version check again (#3428) Fix test for quoted lang messages (#3424) Update gradle from 4.3 to 4.3.1 Fix #3411: ordering of fields in customized entry types works again (#3422) Backport of syncLang to python2 (#3420) Remove Versioneye badge Fix some error prone warnings Fix for issue #2721 append to a field (#3395) Fix travis - hopefully Remove 3.x changelog (#3250) Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library Try to enable LGTM Update guava from 23.2 -> 23.3 (#3409) Update wiremock from 2.8.0 -> 2.10.1 Move groups field from others to general (#3407) Fix checkstyle issues to repair build Fix #3046: No longer allow duplicate fields in customized entry types (#3405) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seemed to be the consent in #3213.
gradle localizationUpdate?