Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hint for checking master version #3439

Merged
merged 3 commits into from
Nov 19, 2017
Merged

Add Hint for checking master version #3439

merged 3 commits into from
Nov 19, 2017

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Nov 17, 2017

I added a tasklist checkbox with the hint to verify the problem with the latest master

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 17, 2017
@Siedlerchr Siedlerchr requested a review from koppor November 17, 2017 17:04
@halirutan
Copy link
Collaborator

Good idea. We have too many issue reports that still use 4.0 and report things that are already fixed. I think at the current pace of changes that are made, working towards a big 4.1 release is not the best course of action. We have reworked so many things. Shouldn't we push an update soon?

@LinusDietz
Copy link
Member

Actually, I'm against this.
The underlying problem is, that we have introduced too many bugs in our major releases lately which were, of course, reported quite often.

As @halirutan said, we should release more often and the problem should go away again.

Copy link
Member

@lenhard lenhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of merging this. There's no damage done by adding a checkbox here.

Regarding the release, I think the "blocker" at the moment is the fact that our code signing certificate has expired. Once @koppor has the replacement ready, we should release immediately.

@Siedlerchr
Copy link
Member Author

Even when the release is stable, the dev Version could already contain a bug fix for an issue present in release. Therefore it makes sense to check the latest dev before

@halirutan
Copy link
Collaborator

I'm definitely in favor of this as well. It is a good thing to ask users "hey, have you checked our latest dev release?" Especially, since some of them might not even be aware of that there is an active develop-version that they can try.

@Siedlerchr Siedlerchr merged commit 98d980e into master Nov 19, 2017
@Siedlerchr Siedlerchr deleted the Siedlerchr-patch-1 branch November 19, 2017 10:00
Siedlerchr added a commit that referenced this pull request Nov 19, 2017
* upstream/master: (30 commits)
  Add Hint for checking master version (#3439)
  Replace LinkedFiles backslashes with forward slashes (#3403)
  fix isbn result from chimbori (#3442)
  Feature java version check again (#3428)
  Fix test for quoted lang messages (#3424)
  Update gradle from 4.3 to 4.3.1
  Fix #3411: ordering of fields in customized entry types works again (#3422)
  Backport of syncLang to python2 (#3420)
  Remove Versioneye badge
  Fix some error prone warnings
  Fix for issue #2721 append to a field (#3395)
  Fix travis - hopefully
  Remove 3.x changelog (#3250)
  Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library
  Try to enable LGTM
  Update guava from 23.2 -> 23.3 (#3409)
  Update wiremock from 2.8.0 -> 2.10.1
  Move groups field from others to general (#3407)
  Fix checkstyle issues to repair build
  Fix #3046: No longer allow duplicate fields in customized entry types (#3405)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants