Strip invalid prolog when loading CitationStyles #3404
Conversation
lenhard
added
the
status: ready-for-review
| @@ -71,7 +71,9 @@ private static CitationStyle createCitationStyleFromSource(final String source, | |||
| String title = ((CharacterData) titleNode.item(0).getFirstChild()).getData(); | |||
|
|
|||
| return new CitationStyle(filename, title, source); | |||
| } catch (ParserConfigurationException | SAXException | IOException e) { | |||
| } catch (SAXException ignore) { | |||
| // is triggered when a use has not configured CitationStyles -> ignore | |||
There was a problem hiding this comment.
Is there no easy way to prevent the exception from being triggered when the user actually does not use citation styles (I suspect these null checks in the beginning should actually serve this job, although they fail obviously). Reason: I think these SAX errors also appears if a user uses a citation style but the parsing fails for some reason. In this case the logged error message is actually helpful.
If there is no easy way to prevent the exception, then I'm fine with merging this PR.
There was a problem hiding this comment.
You are right of course, I should rather track down the origin. The problem lies in the citationstyles. The first line of some of the styles is broken. For example, the style university-of-york-vancouver.csl looks like this ?<?xml version="1.0" encoding="utf-8"?> and is invalid because it starts with a question mark.
That should be fixed at the end of the citation styles. For now, I have pushed a fix on our side that removes all invalid content in the prolog, i.e. everything before the first <. That way all styles can be processed and the error is gone.
lenhard
changed the title
* upstream/master: (26 commits) Fix test for quoted lang messages (#3424) Update gradle from 4.3 to 4.3.1 Fix #3411: ordering of fields in customized entry types works again (#3422) Backport of syncLang to python2 (#3420) Remove Versioneye badge Fix some error prone warnings Fix for issue #2721 append to a field (#3395) Fix travis - hopefully Remove 3.x changelog (#3250) Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library Try to enable LGTM Update guava from 23.2 -> 23.3 (#3409) Update wiremock from 2.8.0 -> 2.10.1 Move groups field from others to general (#3407) Fix checkstyle issues to repair build Fix #3046: No longer allow duplicate fields in customized entry types (#3405) Strip invalid prolog when loading CitationStyles (#3404) Integrity check "Abbreviation Detection" detects abbreviated names for journals and booktitles based on the internal list instead of only looking for "." signs. (#3362) Update gradle from 4.2.1 to 4.3 Update gradle from 4.2.1 to 4.3 ...
* upstream/master: (23 commits) Feature java version check again (#3428) Fix test for quoted lang messages (#3424) Update gradle from 4.3 to 4.3.1 Fix #3411: ordering of fields in customized entry types works again (#3422) Backport of syncLang to python2 (#3420) Remove Versioneye badge Fix some error prone warnings Fix for issue #2721 append to a field (#3395) Fix travis - hopefully Remove 3.x changelog (#3250) Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library Try to enable LGTM Update guava from 23.2 -> 23.3 (#3409) Update wiremock from 2.8.0 -> 2.10.1 Move groups field from others to general (#3407) Fix checkstyle issues to repair build Fix #3046: No longer allow duplicate fields in customized entry types (#3405) Strip invalid prolog when loading CitationStyles (#3404) Integrity check "Abbreviation Detection" detects abbreviated names for journals and booktitles based on the internal list instead of only looking for "." signs. (#3362) Update gradle from 4.2.1 to 4.3 ...
Fixes #3389 by skipping invalid parts of the prolog of citation styles.
gradle localizationUpdate?