Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try fixing rpm uninstall error #12217

Merged
merged 8 commits into from
Dec 9, 2024
Merged

try fixing rpm uninstall error #12217

merged 8 commits into from
Dec 9, 2024

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Nov 21, 2024 •
edited
Loading

add COMMON_SCRIPTS

refs openjdk/jdk@7848ed7

Fixes #12213

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr mentioned this pull request Nov 21, 2024
Closed
2 tasks
@Siedlerchr
try to add more stuff from the spec file
7eac59b
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-rpm-uninstall
26d1968 
* upstream/main:
  [OO] Major performance improvements & fixes (#12221)
  move check for invalid characters to linked files editor (#12219)
  Update Gradle Wrapper from 8.11 to 8.11.1 (#12218)
@Siedlerchr
Copy link
Member Author

I tried more stuff based on https://github.com/openjdk/jdk/blob/jdk-23%2B37/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.spec

@koppor
Copy link
Member

koppor commented Nov 29, 2024

Current state: Still not working: #12213 (comment)

Should we work on a Dockerfile to ease development?

@Siedlerchr
Copy link
Member Author

The thing is, I looked into the generated rpm file and the script do_if_file_belongs_to_single_package is there - but now multiple times....

grafik

@Siedlerchr
Copy link
Member Author

wil try to setup javafx reproducer

@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-rpm-uninstall
137c0a0 
* upstream/main:
  New Crowdin updates (#12264)
  New Crowdin updates (#12263)
  11219 adapt UI font size (#12042)
  Added support for (biblatex) `langid` to be an optional field in entry editor (#12071)
  improve unlinked files dialog (#12195)
  Reword 0034-use-citation-key-for-grouping-chat-messages.md (#12183)
  Bump dev.langchain4j:langchain4j-open-ai from 0.36.0 to 0.36.2 (#12259)
  Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#12258)
  Bump tech.units:indriya from 2.2 to 2.2.1 (#12257)
  Bump org.jetbrains.kotlin:kotlin-stdlib-jdk8 from 2.0.21 to 2.1.0 (#12256)
  Bump io.github.classgraph:classgraph from 4.8.177 to 4.8.179 (#12255)
  Bump src/main/resources/csl-styles from `b90b81a` to `6b7b611` (#12254)
  Add hints on research (and BibTeX) to README.md (#12253)
  Disable non-working Openrewrite recipe
  always set maximized  to false on exit for mac (#12248)
@Siedlerchr
remove spec file
c7d4a95
@Siedlerchr
Copy link
Member Author

Trying with no custom spec file so defautl should be used

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr enabled auto-merge December 9, 2024 14:26
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 9, 2024
@Siedlerchr Siedlerchr added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 5547531 Dec 9, 2024
27 checks passed
@Siedlerchr Siedlerchr deleted the fix-rpm-uninstall branch December 9, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HoussemNasri HoussemNasri HoussemNasri approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

packaging? rpm remove does not work
3 participants
@Siedlerchr @koppor @HoussemNasri