-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OO] Major performance improvements & fixes #12221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
Feels weird to not pass my own tests 😅 |
Looks good. Thanks for keeping up the work on your code. |
CSL4LibreOffice - Performance improvements and fixes
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/697
Reduces the number of UNO API calls -
a) The
OOTextIntoOO#write()
method by default shifts the cursor to the end of the text after operations are done, so callingcursor.collapseToEnd()
everywhere is needless.b) Explicit deletion of extra newlines/paragraph breaks using
cursor.setString()
is no longer needed in case of numeric styles - RegEx intransformHTML
is now adapted to handle it before it is inserted into the document, which is way faster.Changes newlines in bibliography to paragraph breaks, improving performance of documents with a large number of bibliographic entries drastically, as per information from https://bugs.documentfoundation.org/show_bug.cgi?id=163984
Old:
New:
Fixes extra newlines before each numeric bibliographic entry, which also used to cause one to be placed after the title (see comparison above)
Some miscellaneous documentation enhancements
Credits to @ThiloteE for investigating and the @LibreOffice community for prompt support!
Mandatory checks
Change in[Changes in unreleased]CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)Tests created for changes (if applicable)