Improve code of BibDataBaseDiff

[koppor]

Made during thinking of #4877 (but did not work)

Mandatory checks

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[Siedlerchr]

I could stil reproduce it sometimes with the file field, it seems the formatting differs, I have autosve enabled and reformat is disabled. I stored the bib file in nextcloud synced folder. (tested on mac)

see the entries:
test2entries.zip

If you quickly type into the comemnt field some gibberish text and wait it will also trigger the dialog.

[koppor]

I would take a different approach to disable the changes if the file in disk is the saved file.

Reason: Save actions modify the file. That should happen silently...

[Siedlerchr]

Yes, that seems like a good idea, but isn't the change scanner basically doing this? Except that we compare it with the in memory library

[koppor]

Yes, that seems like a good idea, but isn't the change scanner basically doing this? Except that we compare it with the in memory library

Memory is not equal to disk because of white space removal. File field could be different thing. I don't know yet.

Memory and disk is same for applied save actions, because these propagate back to the memory - but lead to cursor jumping.

[Siedlerchr]

Memory is not equal to disk because of white space removal. File field could be different thing. I don't know yet.

Another thing related to autosave: Should autosave trigger only when leaving the field?

File field is treated as mulitline field at least in FieldContentFormatter
For file we have FileFieldwriter . however that is directly applied after setting the field

[github-actions]

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.