Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for BackgroundTask (and improve code) #11346

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Add documentation for BackgroundTask (and improve code) #11346

merged 3 commits into from
Jun 3, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented May 29, 2024

Small improvement of our JavaDoc while discussiong things.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor @calixtus @LoayGhreeb
Add documentation for BackgroundTask (and improve code)
8f5af44 
Co-authored-by: Carl Christian Snethlage <[email protected]>
Co-authored-by: Loay Ghreeb <[email protected]>
@koppor koppor added the dev: code-quality Issues related to code or architecture decisions label May 29, 2024
calixtus
calixtus previously approved these changes May 29, 2024
View reviewed changes
@LoayGhreeb LoayGhreeb force-pushed the improve-background-task branch from df793f8 to 6119029 Compare May 30, 2024 12:54
@Siedlerchr Siedlerchr enabled auto-merge June 3, 2024 19:08
@Siedlerchr Siedlerchr added this pull request to the merge queue Jun 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit 109600b Jun 3, 2024
21 checks passed
@Siedlerchr Siedlerchr deleted the improve-background-task branch June 3, 2024 19:22
Siedlerchr added a commit that referenced this pull request Jun 8, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/Main' into fix-4877
d34db46 
* upstream/Main:
  Disable whole CiteSeer since it does not work as of 2024-05-20 (#11315)
  Improve devdocs for localization (#11356)
  Add documentation for BackgroundTask (and improve code) (#11346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus left review comments

Assignees
No one assigned
Labels
dev: code-quality Issues related to code or architecture decisions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koppor @Siedlerchr @calixtus @LoayGhreeb