Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable whole CiteSeer since it does not work as of 2024-05-20 #11315

Merged
merged 6 commits into from
Jun 8, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented May 20, 2024

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor marked this pull request as draft May 20, 2024 19:25
@koppor
Copy link
Member Author

koppor commented May 20, 2024

There is only one fetcher tests shown failing. Trying to get this fixed (so that all failing tests are shown)

@koppor
Copy link
Member Author

koppor commented May 24, 2024

This PR is marked as draft to investigate why only one failing fetcher test is displayed. There should be more fails.

Maybe refs #9797 and #11300

@koppor
Copy link
Member Author

koppor commented May 24, 2024

Before:

440 tests completed, 1 failed, 114 skipped
FAILURE: Executed 440 tests in 5m 50s (1 failed, 114 skipped)

After disablement of maxParallelForks

440 tests completed, 1 failed, 114 skipped

main:

440 tests completed, 2 failed, 114 skipped

Thus, no change.

@koppor
Copy link
Member Author

koppor commented May 24, 2024

Now, the hickups of the tests is finished:

SUCCESS: Executed 440 tests in 6m 6s (114 skipped)

@koppor
Copy link
Member Author

koppor commented May 24, 2024

Locally, I do have issues though:

image

@koppor koppor marked this pull request as ready for review June 4, 2024 22:11
@koppor
Copy link
Member Author

koppor commented Jun 4, 2024

I will try to investigate gradle's behavior in #11282

Thus, this is good to go.

@koppor koppor enabled auto-merge June 4, 2024 22:12
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor added this pull request to the merge queue Jun 8, 2024
Merged via the queue into main with commit 5ba6397 Jun 8, 2024
29 of 30 checks passed
@koppor koppor deleted the disable-citeseer branch June 8, 2024 17:46
Siedlerchr added a commit that referenced this pull request Jun 8, 2024
* upstream/Main:
  Disable whole CiteSeer since it does not work as of 2024-05-20 (#11315)
  Improve devdocs for localization (#11356)
  Add documentation for BackgroundTask (and improve code) (#11346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: fetcher status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants