-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed saving radio button choice under specified keywords #10255
Conversation
wow, you are fast! Awesome :D |
Thanks so much!!! |
Thanks for the contribution! I tested the changes locally and couldn't replicate the bug anymore. However, one thing that still bugs me, is when you select the "Specified keywords" option while creating a new group, none of the generation options are selected. That doesn't seem right... @DohaRamadan do you think you can get it fixed? Maybe by selecting the first option as a default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just the minor issue described above. Can be handled in a later pull request if it's too much trouble.
Sure, i will do it no problem. |
It's relevant to the pull request purpose, so I would put it here, but if it's gonna take time, you can always create a follow up PR. |
Should be a followup PR. Since we want to release tonight, I would like to ask you to create a new issue from your comment and we merge this one now. |
@DohaRamadan Please comment on #10269 so I can assign you. |
* upstream/main: (53 commits) Update CHANGELOG.md Update CHANGELOG.md Update CHANGELOG.md adjust snapcraft Show development information Add merge_group trigger on tests and deployment fix changelog link change to release Update CHANGELOG.md Updated external-libraries.md (JabRef#10272) Update Java Keyring dependency (JabRef#10252) New translations JabRef_en.properties (Dutch) Remove CCS as it is no longer available (JabRef#10270) New translations JabRef_en.properties (Dutch) Fixed saving radio button choice under specified keywords (JabRef#10255) Unlocalize LOGGER output (and change log level) Squashed 'buildres/csl/csl-styles/' changes from 795ad0c772..2a122e3fa0 Update CHANGELOG.md Update CHANGELOG.md Fixed not showing selected group properties ...
Fixed that checked-out radio buttons under specified keywords were not displayed as checked after closing and reopening the edit group window
Fixes #10248
before:
after:
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)