Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed saving radio button choice under specified keywords #10255

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

DohaRamadan
Copy link
Contributor

Fixed that checked-out radio buttons under specified keywords were not displayed as checked after closing and reopening the edit group window
Fixes #10248

before:
before2

after:
after2

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@ThiloteE
Copy link
Member

wow, you are fast! Awesome :D

@ghost
Copy link

ghost commented Aug 31, 2023

Thanks so much!!!

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 1, 2023
@HoussemNasri
Copy link
Member

Thanks for the contribution! I tested the changes locally and couldn't replicate the bug anymore.

However, one thing that still bugs me, is when you select the "Specified keywords" option while creating a new group, none of the generation options are selected. That doesn't seem right...

@DohaRamadan do you think you can get it fixed? Maybe by selecting the first option as a default.

image

Copy link
Member

@HoussemNasri HoussemNasri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just the minor issue described above. Can be handled in a later pull request if it's too much trouble.

@DohaRamadan
Copy link
Contributor Author

Sure, i will do it no problem.
Should i add it to this pull request or to a new one?

@HoussemNasri
Copy link
Member

It's relevant to the pull request purpose, so I would put it here, but if it's gonna take time, you can always create a follow up PR.

@calixtus
Copy link
Member

calixtus commented Sep 1, 2023

Should be a followup PR. Since we want to release tonight, I would like to ask you to create a new issue from your comment and we merge this one now.

@calixtus calixtus merged commit 740bd09 into JabRef:main Sep 1, 2023
@HoussemNasri
Copy link
Member

@DohaRamadan Please comment on #10269 so I can assign you.

Siedlerchr added a commit to Luggas4you/jabref that referenced this pull request Sep 2, 2023
* upstream/main: (53 commits)
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update CHANGELOG.md
  adjust snapcraft
  Show development information
  Add merge_group trigger on tests and deployment
  fix changelog link
  change to release
  Update CHANGELOG.md
  Updated external-libraries.md (JabRef#10272)
  Update Java Keyring dependency (JabRef#10252)
  New translations JabRef_en.properties (Dutch)
  Remove CCS as it is no longer available (JabRef#10270)
  New translations JabRef_en.properties (Dutch)
  Fixed saving radio button choice under specified keywords (JabRef#10255)
  Unlocalize LOGGER output (and change log level)
  Squashed 'buildres/csl/csl-styles/' changes from 795ad0c772..2a122e3fa0
  Update CHANGELOG.md
  Update CHANGELOG.md
  Fixed not showing selected group properties
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
groups status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

group properties (specified keywords) not saving radiobutton choice
5 participants