Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed saving radio button choice under specified keywords #10255

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Fixed saving radio button choice under specified keywords #10255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d2b056d
Fixed saving radio button choice under specified keywords
DohaRamadan Aug 31, 2023
7a01649
Update CHANGELOG.md
DohaRamadan Aug 31, 2023
2053105
Merge branch 'main' into branch3
DohaRamadan Aug 31, 2023
07259f0
Update CHANGELOG.md
DohaRamadan Aug 31, 2023
69a5787
Merge branch 'main' into branch3
Siedlerchr Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- We fixed an issue where the ACM Portal search sometimes would not return entries for some search queries when the article author had no given name [#10107](https://github.com/JabRef/jabref/issues/10107)
- We fixed an issue that caused high CPU usage and a zombie process after quitting JabRef because of author names autocompletion [#10159](https://github.com/JabRef/jabref/pull/10159)
- We fixed an issue where files with illegal characters in the filename could be added to JabRef. [#10182](https://github.com/JabRef/jabref/issues/10182)
- We fixed that checked-out radio buttons under "specified keywords" were not displayed as checked after closing and reopening the "edit group" window. [#10248](https://github.com/JabRef/jabref/issues/10248)
- We fixed that when editing groups, checked-out properties such as case sensitive and regular expression (under "Free search expression") were not displayed checked. [#10108](https://github.com/JabRef/jabref/issues/10108)

### Removed
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/org/jabref/gui/groups/GroupDialogViewModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ public AbstractGroup resultConverter(ButtonType button) {
// Set default value for delimiters: ',' for base and '>' for hierarchical
char delimiter = ',';
char hierarDelimiter = Keyword.DEFAULT_HIERARCHICAL_DELIMITER;
autoGroupKeywordsOptionProperty.setValue(Boolean.TRUE);
// Modify values for delimiters if user provided customized values
if (!autoGroupKeywordsDelimiterProperty.getValue().isEmpty()) {
delimiter = autoGroupKeywordsDelimiterProperty.getValue().charAt(0);
Expand Down Expand Up @@ -423,11 +424,13 @@ public void setValues() {

if (editedGroup.getClass() == AutomaticKeywordGroup.class) {
AutomaticKeywordGroup group = (AutomaticKeywordGroup) editedGroup;
autoGroupKeywordsOptionProperty.setValue(Boolean.TRUE);
autoGroupKeywordsDelimiterProperty.setValue(group.getKeywordDelimiter().toString());
autoGroupKeywordsHierarchicalDelimiterProperty.setValue(group.getKeywordHierarchicalDelimiter().toString());
autoGroupKeywordsFieldProperty.setValue(group.getField().getName());
} else if (editedGroup.getClass() == AutomaticPersonsGroup.class) {
AutomaticPersonsGroup group = (AutomaticPersonsGroup) editedGroup;
autoGroupPersonsOptionProperty.setValue(Boolean.TRUE);
autoGroupPersonsFieldProperty.setValue(group.getField().getName());
}
} else if (editedGroup.getClass() == TexGroup.class) {
Expand Down