Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java Keyring dependency #10252

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Update Java Keyring dependency #10252

merged 1 commit into from
Sep 1, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Aug 30, 2023

Java Keyring released a new version, which integrated our fix javakeyring/java-keyring#90.

Follow-up to #10224, refs #8055.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the dependencies Pull requests that update a dependency file label Aug 30, 2023
@koppor koppor requested a review from calixtus August 30, 2023 23:09
@koppor koppor added this to the v5.10 milestone Aug 30, 2023
@koppor
Copy link
Member Author

koppor commented Aug 30, 2023

Refs #10044 (comment).

@credmond Could you test this PR on your GNOME. Hopefully, it works. If not, we have some bigger issues to solve. (The next comment should contain the deep link to the directory of the build)

Refs javakeyring/java-keyring#90 (where we updated a dependency of Java Keyring to get it work) and advisedtesting/AdvisedTesting#115 (where we updated a testing dependency of Java Keyring to enable testing it on JDK17)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@credmond
Copy link
Contributor

credmond commented Sep 1, 2023

Refs #10044 (comment).

@credmond Could you test this PR on your GNOME. Hopefully, it works. If not, we have some bigger issues to solve. (The next comment should contain the deep link to the directory of the build)

Refs javakeyring/java-keyring#90 (where we updated a dependency of Java Keyring to get it work) and advisedtesting/AdvisedTesting#115 (where we updated a testing dependency of Java Keyring to enable testing it on JDK17)

Unfortunately, same problem. The stack-trace @ 15:51 occurred after I attempted to save a proxy password:

Messages are not initialized before accessing key: Display help on command line options
2023-09-01 15:50:58 [main] org.jabref.preferences.JabRefPreferences.getProxyPassword()
WARN: JabRef could not open the key store
Sep 01, 2023 3:51:00 PM com.sun.javafx.application.PlatformImpl startup
WARNING: Unsupported JavaFX configuration: classes were loaded from 'module org.jabref.merged.module', isAutomatic: false, isOpen: true
2023-09-01 15:51:01 [JavaFX Application Thread] org.jabref.gui.StateManager.setActiveDatabase()
INFO: No open database detected
2023-09-01 15:51:01 [JavaFX Application Thread] org.jabref.gui.theme.ThemeManager.updateThemeSettings()
INFO: Not updating theme because it hasn't changed
2023-09-01 15:51:01 [JavaFX Application Thread] org.jabref.gui.theme.ThemeManager.updateThemeSettings()
INFO: Theme set to Theme{type=DEFAULT, name=''} with base css StyleSheet{jrt:/org.jabref/org/jabref/gui/Base.css}

(JabRef:4981): Gdk-WARNING **: 15:51:01.928: XSetErrorHandler() called with a GDK error trap pushed. Don't do that.
Sep 01, 2023 3:51:01 PM com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
WARNING: Resource "" not found.
Sep 01, 2023 3:51:05 PM com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
WARNING: Resource "" not found.
2023-09-01 15:51:08 [JavaFX Application Thread] org.jabref.preferences.JabRefPreferences.getFetcherKeysFromKeyring()
WARN: JabRef could not open the key store
2023-09-01 15:51:09 [JavaFX Application Thread] org.jabref.logic.util.OS.isKeyringAvailable()
WARN: Credential store not supported.
2023-09-01 15:51:09 [JavaFX Application Thread] org.jabref.logic.util.OS.isKeyringAvailable()
WARN: Credential store not supported.
2023-09-01 15:51:20 [JavaFX Application Thread] org.jabref.preferences.JabRefPreferences.clearCustomFetcherKeys()
ERROR: Unable to open key store
2023-09-01 15:51:20 [JavaFX Application Thread] org.jabref.preferences.JabRefPreferences.clearCustomFetcherKeys()
ERROR: Unable to open key store
2023-09-01 15:51:20 [JavaFX Application Thread] org.jabref.preferences.JabRefPreferences.clearCustomFetcherKeys()
ERROR: Unable to open key store
2023-09-01 15:51:20 [JavaFX Application Thread] org.jabref.preferences.JabRefPreferences.clearCustomFetcherKeys()
ERROR: Unable to open key store
2023-09-01 15:51:20 [JavaFX Application Thread] org.jabref.preferences.JabRefPreferences.clearCustomFetcherKeys()
ERROR: Unable to open key store
2023-09-01 15:51:20 [JavaFX Application Thread] org.jabref.preferences.JabRefPreferences.setProxyPassword()
WARN: Unable to open key store: com.github.javakeyring.BackendNotSupportedException: No available keyring backend found
	at [email protected]/com.github.javakeyring.internal.KeyringBackendFactory.create(Unknown Source)
	at [email protected]/com.github.javakeyring.Keyring.create(Unknown Source)
	at [email protected]/org.jabref.preferences.JabRefPreferences.setProxyPassword(Unknown Source)
	at [email protected]/org.jabref.preferences.JabRefPreferences.lambda$getProxyPreferences$48(Unknown Source)
	at [email protected]/com.sun.javafx.binding.ExpressionHelper$SingleChange.fireValueChangedEvent(Unknown Source)
	at [email protected]/com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(Unknown Source)
	at [email protected]/javafx.beans.property.StringPropertyBase.fireValueChangedEvent(Unknown Source)
	at [email protected]/javafx.beans.property.StringPropertyBase.markInvalid(Unknown Source)
	at [email protected]/javafx.beans.property.StringPropertyBase.set(Unknown Source)
	at [email protected]/javafx.beans.property.StringPropertyBase.set(Unknown Source)
	at [email protected]/org.jabref.logic.net.ProxyPreferences.setPassword(Unknown Source)
	at [email protected]/org.jabref.gui.preferences.network.NetworkTabViewModel.storeSettings(Unknown Source)
	at [email protected]/org.jabref.gui.preferences.AbstractPreferenceTabView.storeSettings(Unknown Source)
	at [email protected]/org.jabref.gui.preferences.PreferencesDialogViewModel.storeAllSettings(Unknown Source)
	at [email protected]/org.jabref.gui.preferences.PreferencesDialogView.savePreferencesAndCloseDialog(Unknown Source)
	at [email protected]/org.jabref.gui.preferences.PreferencesDialogView.lambda$new$0(Unknown Source)
	at [email protected]/org.jabref.gui.util.ControlHelper.lambda$setAction$0(Unknown Source)
	at [email protected]/com.sun.javafx.event.CompositeEventHandler$NormalEventFilterRecord.handleCapturingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.CompositeEventHandler.dispatchCapturingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventHandlerManager.dispatchCapturingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventHandlerManager.dispatchCapturingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.CompositeEventDispatcher.dispatchCapturingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
	at [email protected]/javafx.event.Event.fireEvent(Unknown Source)
	at [email protected]/javafx.scene.Node.fireEvent(Unknown Source)
	at [email protected]/javafx.scene.control.Button.fire(Unknown Source)
	at [email protected]/com.sun.javafx.scene.control.behavior.ButtonBehavior.mouseReleased(Unknown Source)
	at [email protected]/com.sun.javafx.scene.control.inputmap.InputMap.handle(Unknown Source)
	at [email protected]/com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
	at [email protected]/javafx.event.Event.fireEvent(Unknown Source)
	at [email protected]/javafx.scene.Scene$MouseHandler.process(Unknown Source)
	at [email protected]/javafx.scene.Scene.processMouseEvent(Unknown Source)
	at [email protected]/javafx.scene.Scene$ScenePeerListener.mouseEvent(Unknown Source)
	at [email protected]/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(Unknown Source)
	at [email protected]/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at [email protected]/com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$2(Unknown Source)
	at [email protected]/com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(Unknown Source)
	at [email protected]/com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(Unknown Source)
	at [email protected]/com.sun.glass.ui.View.handleMouseEvent(Unknown Source)
	at [email protected]/com.sun.glass.ui.View.notifyMouse(Unknown Source)
	at [email protected]/com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
	at [email protected]/com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
2023-09-01 15:51:20 [JavaFX Application Thread] org.jabref.gui.JabRefDialogService.notify()
INFO: Preferences recorded.
2023-09-01 15:51:20 [JavaFX Application Thread] org.jabref.logic.util.OS.isKeyringAvailable()
WARN: Credential store not supported.
2023-09-01 15:51:21 [JavaFX Application Thread] org.jabref.logic.util.OS.isKeyringAvailable()
WARN: Credential store not supported.

@Siedlerchr Siedlerchr modified the milestones: v5.10, 5.11 Sep 1, 2023
@koppor
Copy link
Member Author

koppor commented Sep 1, 2023

We tried on MacOS and Windows. We update, because it does not make things worse. Follow-up issue #10274 created.

@koppor koppor merged commit 605bfa1 into main Sep 1, 2023
@koppor koppor deleted the update-java-keyring branch September 1, 2023 22:20
@credmond
Copy link
Contributor

credmond commented Sep 2, 2023

I found the root cause, I believe. I'll update the other ticket with info.

@Siedlerchr
Copy link
Member

@credmond Yeah that sounds great, thanks already in advance!

Siedlerchr added a commit to Luggas4you/jabref that referenced this pull request Sep 2, 2023
* upstream/main: (53 commits)
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update CHANGELOG.md
  adjust snapcraft
  Show development information
  Add merge_group trigger on tests and deployment
  fix changelog link
  change to release
  Update CHANGELOG.md
  Updated external-libraries.md (JabRef#10272)
  Update Java Keyring dependency (JabRef#10252)
  New translations JabRef_en.properties (Dutch)
  Remove CCS as it is no longer available (JabRef#10270)
  New translations JabRef_en.properties (Dutch)
  Fixed saving radio button choice under specified keywords (JabRef#10255)
  Unlocalize LOGGER output (and change log level)
  Squashed 'buildres/csl/csl-styles/' changes from 795ad0c772..2a122e3fa0
  Update CHANGELOG.md
  Update CHANGELOG.md
  Fixed not showing selected group properties
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants