When changing a group color, no dialog should appear

[koppor]

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

Windows 10

Checked with the latest development build

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

1. Edit the properties of a group
2. Change the color
3. Click "OK"
4. Dialog "Change of Grouping Method" appears
   

Expected behavior: No dialog appears, just the group color should change

Refs #7325

Appendix

No response

[koppor]

No triggered reassignment should then also keep the git diff noise to a minimum

Currently, following diff is generated:

[Siedlerchr]

I looked a bit into it, the dialog is called here:

A solution would be to check if there have been changes to the group type or group keywords etc and only display that dialog in this cases.

jabref/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

Lines 183 to 199 in 9d1c448

	public void editGroup(GroupNodeViewModel oldGroup) {
	currentDatabase.ifPresent(database -> {
	Optional<AbstractGroup> newGroup = dialogService.showCustomDialogAndWait(new GroupDialogView(
	dialogService,
	database,
	preferences,
	oldGroup.getGroupNode().getGroup(),
	GroupDialogHeader.SUBGROUP));
	newGroup.ifPresent(group -> {
	// TODO: Keep assignments
	boolean keepPreviousAssignments = dialogService.showConfirmationDialogAndWait(
	Localization.lang("Change of Grouping Method"),
	Localization.lang("Assign the original group's entries to this group?"));
	// WarnAssignmentSideEffects.warnAssignmentSideEffects(newGroup, panel.frame());
	boolean removePreviousAssignments = (oldGroup.getGroupNode().getGroup() instanceof ExplicitGroup)
	&& (group instanceof ExplicitGroup);

[dimitrisdimos00]

Hello there. In which cases is a warning useless except from when changing the color? For example, I'm thinking that when changing the icon of the group, no warning should be shown either. Do we need a warning only for the "Hierarchical context" and "Collect by" options?

[dimitrisdimos00]

Hello?

[Siedlerchr]

Sorry, missed your question.
I guess it makes only sense when the group type or for example the keywords or the separator changed. For color and icon not

[Surabhiramesh]

Hi, we are a group of students studying Master of Computer Science in University of Adelaide and we wanted to check if this issue is available for us to work on for our assignment. And if it is available, we would like to get some valuable inputs based on the previous contributions to this issue.

[koppor]

In which cases is a warning useless except from when changing the color? For example, I'm thinking that when changing the icon of the group, no warning should be shown either.

You are right. Please make a list of all possible cases, where a) no dialog should be opened and b) where a dialog should be opened

Do we need a warning only for the "Hierarchical context" and "Collect by" options?

I am not sure. It should be properly documented and JUnit tests should exist.

[koppor]

@Surabhiramesh The issue is available. Please go ahead. Please also see my last comment.

[ThiloteE]

Welcome and thank you for your engagement. Guidelines for contributing can be found here: https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md. See here for a rough outline of this process. In general, it is advised to open a (draft) pull request early on so that reviewers have time to comment and the general direction of the request becomes clear. This will allow you to receive valuable feedback!

If you have any questions, feel free to ask! Either here at GitHub, or you also can join our gitter chat.