JabRef#8189 - changing a group color, no dialog should appear

Signed-off-by: yukioz <[email protected]>
yukioz · Apr 3, 2022 · 551c28e · 551c28e
1 parent 92071e3
commit 551c28e
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java b/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java
@@ -191,9 +191,21 @@ public void editGroup(GroupNodeViewModel oldGroup) {
 
             newGroup.ifPresent(group -> {
                 // TODO: Keep assignments
-                boolean keepPreviousAssignments = dialogService.showConfirmationDialogAndWait(
-                        Localization.lang("Change of Grouping Method"),
-                        Localization.lang("Assign the original group's entries to this group?"));
+
+                boolean keepPreviousAssignments;
+
+                if(!group.getName().equals(oldGroup.getDisplayName())) {
+
+                    System.out.println(group.getName());
+                    System.out.println(oldGroup.getDisplayName());
+
+                    keepPreviousAssignments = dialogService.showConfirmationDialogAndWait(
+                            Localization.lang("Change of Grouping Method"),
+                            Localization.lang("Assign the original group's entries to this group?"));
+                }
+                else {
+                    keepPreviousAssignments = false;
+                }
                 //        WarnAssignmentSideEffects.warnAssignmentSideEffects(newGroup, panel.frame());
                 boolean removePreviousAssignments = (oldGroup.getGroupNode().getGroup() instanceof ExplicitGroup)
                         && (group instanceof ExplicitGroup);