Group badges don't update after assignment

[Krzmbrzl]

JabRef 5.0.0-dev--2019-10-25----681d6aa6f
Linux 5.0.0-32-generic amd64
Java 12.0.2

• I have tested the latest development version from http://builds.jabref.org/master/ and the problem persists

Steps to reproduce the behavior:

1. Add new entry that is not in any group
2. Manually assign a group to the entry via drag&drop onto an existing group
3. In the entry list, the groups-column is not updated for the newly grouped entry. I have to explicitly switch the displayed group in order for the entry list to refresh and show the group badges (the color stripes) for the new entry. Alternatively a restart does the same.

Thus the entry gets added to that group just fine. It's just the entry list that doesn't get updated on this

[calixtus]

I have tested this behaviour, the group badge updates after about one second.
@Krzmbrzl, would you please do me the favor to test this issue in JabRef with the latest dev version again and to tell, if something changed?

[Krzmbrzl]

I don't have my Linux system at hand right now, so I tested it on Windows using

JabRef 5.0-beta.421--2020-02-14--ec93ad3
Windows 7 6.1 amd64 
Java 13.0.2

and the problem persists.

What does get updated is the number next to the group indicating how many members are in it, but the color-badge in the entry list does not get updated until I switch the displayed group so that the entry list gets updated.

Here are some screenshots illustrating what I mean.
Before switching the displayed group:

and after having switched the displayed group (I also switched back but the badge appears on the first switching):

[calixtus]

Thank you for clearifying. Im looking into this issue.

[calixtus]

I root of the problem is somewhat similar to what is fixed in #5925. But not quite exactly.
The dataset is updated correctly, but the maintable is not updated. Affects both the groups column and the uri column. I did not test the file column, but I'd bet on it. @tobiasdiez as a good insight in the JabRef data model. Maybe he's got an idea?

[tobiasdiez]

I think the problem is in this method:

jabref/src/main/java/org/jabref/gui/maintable/BibEntryTableViewModel.java

Lines 66 to 81 in cc94cca

	public ObservableValue<List<AbstractGroup>> getMatchedGroups(BibDatabaseContext database) {
	SimpleObjectProperty<List<AbstractGroup>> matchedGroups = new SimpleObjectProperty<>(Collections.emptyList());
	Optional<GroupTreeNode> root = database.getMetaData()
	.getGroups();
	if (root.isPresent()) {
	List<AbstractGroup> groups = root.get().getMatchingGroups(entry)
	.stream()
	.map(GroupTreeNode::getGroup)
	.collect(Collectors.toList());
	groups.remove(root.get().getGroup());
	matchedGroups.setValue(groups);
	}
	return matchedGroups;
	}

A observable value is returned, but this one is static and doesn't change if the underlying data in the entry changed (or the groups for that matter).

[tobiasdiez]

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

[Krzmbrzl]

The problem persists in

JabRef 5.0-beta.457--2020-02-22--d38f813
Windows 7 6.1 amd64 
Java 13.0.2

[calixtus]

It's possible you were too quick for us. 😄 After merging, the build server takes about an hour to upload the latest build to builds.jabref.org.

[Krzmbrzl]

I was too quick at first. Then I waited for the CI to complete and downloaded it again.

You can see from the commit-hash (d38f813) that it is indeed the build that is currently up-to-date with the master-branch :)