[blocked by #5571 - can be merged afterwards] Add rpm spec file to add/remove json extension files

[LyzardKing]

This PR simply adds the RPM spec file to add/remove the json files needed
by the browser extension (like the deb postinst/postrm scripts)
I just edited the jpackage template with the additions.
It's not tested yet so I can use the build repo to generate the rpm and test it from there.

---

• Change in CHANGELOG.md described
• Tests created for changes
• Manually tested changed features in running JabRef
• Screenshots added in PR description (for bigger UI changes)
• Ensured that the git commit message is a good one
• Check documentation status (Issue created for outdated help page at help.jabref.org?)

[tobiasdiez]

It's a bit unfortunate that we need to copy the file from jpackage and add things ourselves. (Because then updates to these files are no longer automatically included and we have to manually update them with the latest upstream changes). But I guess for now that's the best option...

[LyzardKing]

The alternative would be a custom script to replace the specific parts we need to add..
That would mean running a custom script during the jpackage run though..

[LyzardKing]

Why is the python script failing?
Do we need the python2 alternative or can all the code run on python3?

[Siedlerchr]

Normally python 3 should be available

[LyzardKing]

Apparently ubuntu is trying to run with python2...

[tobiasdiez]

The problem is that your branch still reference the old 64 build of jpackage. Can you please rebase, this should solve the problem.

[Siedlerchr]

Don't you have to call python3 for executing if both is installed?

https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners

[LyzardKing]

Rebased on master.. I thought it was already following the latest update..

[koppor]

All checks green - file looks OK. - Can it go in?

@LyzardKing It would be nice if you checked the check items in your pull request message - or just deleted the check list. - In that way, other contributors see that the items are either done or not there.

[LyzardKing]

Hi!
I was actually waiting to manually test it.
I'll try tomorrow to run on a vm and see if the changes work.
This is supposed to add/remove files at install/uninstall
so it needs some proper testing..
Although this test as well could be automated..

[koppor]

Automatically testing by executing the steps on docker images? Sounds good 😅👍 Galileo Sartor <[email protected]> schrieb am Fr., 8. Nov. 2019, 00:12:

…

Hi! I was actually waiting to manually test it. I'll try tomorrow to run on a vm and see if the changes work. This is supposed to add/remove files at install/uninstall so it needs some proper testing.. Although this test as well could be automated.. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5574?email_source=notifications&email_token=AAKNU7UURDOTIERMD2SCERDQSSOFFA5CNFSM4JKLAUQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDOE6DA#issuecomment-551309068>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKNU7QUXWSRYIFYC5ASBHDQSSOFFANCNFSM4JKLAUQA> .

[LyzardKing]

Once the images are built we could use another github actions file (and tell it to run after deployment.yml)
In that one we could install the deb/rpm (It should be possible with the win/macos images as well I guess)
Then we can start jabref, add (via the cli) some references..something like that..

[koppor]

Oh, yeah, I see. Maybe just a trial-and-error with a virutal machine is faster. I hope that this is a one-time thing and some script maintenance won't be necessary.

[LyzardKing]

For this PR there should be no further changes,
but it might be useful to check if jabref starts and works.
A simple set of tests to verify if errors like the one regarding imports
are introduced on different PRs.
A more "real use" simultation than the junit tests

[LyzardKing]

This was built with the chrome json files paths.
I removed to be able to test the firefox one...
Once the chromium PR is merged the last commit on this PR can be removed
Still testing....

[LyzardKing]

@tobiasdiez It works with the firefox json..
It needs only a rebase on master.
Should we wait for the chromium part to merge?
Or should we first merge this then add the additional json paths?

[LyzardKing]

I rebased on master to be sure the renaming extension works
and the paths are correct.

[koppor]

@LyzardKing If you don't mind, just remove the last commit (should be easy with gitk --> right click on the commit description and say "Reset rpm-postinst to here" and then choose "hard"). Then a git push -f.

The Chromium PR is #5571

[LyzardKing]

The Remove chromium json install in rpm spec is needed because the install will fail until the chromium parts are merged...
So it's probably better, while we debug the chromium stuff, to merge a firefox fix for rpm

[LyzardKing]

And it works!!
In fedora I installed the latest build from this branch, and the latest extension (from master)
I can import succesfully, without the new instance issue, and with the firefox file installed automagically.
I have to fix a typo, because the remove function had an echo instead of rm from my debug tests..

[LyzardKing]

@koppor @tobiasdiez
Removed the chromium commit..
This PR works, but depends on #5571
If we remove the chromium part it can be merged.

[tobiasdiez]

LGTM. I would wait until we merge the Chromium PR.

For reference, https://hg.openjdk.java.net/jdk/sandbox/file/fbaf2e6402ad/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.spec is the base file.