Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetcher broken without anyone noticing #3854

Closed
5 of 6 tasks
stefan-kolb opened this issue Mar 15, 2018 · 2 comments
Closed
5 of 6 tasks

Fetcher broken without anyone noticing #3854

stefan-kolb opened this issue Mar 15, 2018 · 2 comments
Labels
fetcher
Milestone
v4.4

Comments

@stefan-kolb
Copy link
Member

stefan-kolb commented Mar 15, 2018 •
edited by tobiasdiez
Loading

As we have deactivated the tests in Travis we do not notice that they fail.
Right now, a lot of them are actually broken again.
I think this is not a good situation if we are not aware of this.
This is a major functionality for us, even if we hide such errors from the user the results will not be as good as expected when the fetchers are broken.
Need to discuss possibilities in the dev call.

  • ScienceDirect
  • OpenAccessDOI
  • Isbnfetcher just returns wrong result because ebbok.de is broken
  • viaEbook inputstream seems to be empty via code call. browser result is fine. Fix ebook.de #3967
  • MathSciNet no subscription
  • zbMath only available with subscrption (https://zbmath.org/subscription/)
stefan-kolb added a commit that referenced this issue Mar 15, 2018
@stefan-kolb
Fix ScienceDirect fetcher #3854
3a923eb
Siedlerchr added a commit that referenced this issue Mar 16, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/maintable-beta' into fixdragan…
718eb4e 
…drop

* upstream/maintable-beta:
  Update java-string-similarity from 1.0.1 -> 1.1.0
  Update log4j from 2.10.0 -> 2.11.0
  Update guava from 24.0 -> 24.1
  New Crowdin translations (#3853)
  Fetcher refactorings
  Fix ScienceDirect fetcher #3854
  Fix Google Scholar fetcher test
  Fix DBLP fetcher tests
  Move migration to top level package
  New Crowdin translations (#3851)
  Update mysql-connector from 5.1.45 -> 5.1.46
  Update mockito-core from 2.15.0 -> 2.16.0
  New translations JabRef_en.properties (Spanish)
  New translations Menu_en.properties (Spanish)
  First available entry selected after pressing ESC as well
  Pressing ESC now clears search field
Siedlerchr added a commit that referenced this issue Mar 17, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/maintable-beta' into selectFil…
5305d43 
…esDlg

* upstream/maintable-beta: (346 commits)
  add missing localization
  fix keybinding of entry editor add missing keybinding of search
  Update java-string-similarity from 1.0.1 -> 1.1.0
  Update log4j from 2.10.0 -> 2.11.0
  Update guava from 24.0 -> 24.1
  New Crowdin translations (#3853)
  Fetcher refactorings
  Fix ScienceDirect fetcher #3854
  Fix Google Scholar fetcher test
  Fix DBLP fetcher tests
  Move migration to top level package
  New Crowdin translations (#3851)
  Update Eclipse style to intellij style (#3827)
  fix some not on fx thread dialogs in preferences
  fix inital save error Convert last dialog to javafx refactor exception
  Update mysql-connector from 5.1.45 -> 5.1.46
  Update mockito-core from 2.15.0 -> 2.16.0
  New translations JabRef_en.properties (Spanish)
  New translations Menu_en.properties (Spanish)
  Merge changes for renamed actions
  ...
stefan-kolb added a commit that referenced this issue Apr 20, 2018
@stefan-kolb
LOC test #3854
07c5731
@stefan-kolb stefan-kolb mentioned this issue Apr 20, 2018
Merged
@stefan-kolb
Copy link
Member Author

@tobiasdiez Did you have a chance to test the remaining two fetchers?

Siedlerchr added a commit that referenced this issue Apr 25, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into maintable-beta
a6b0996 
* upstream/master: (47 commits)
  Fix xmp exporter (#3964)
  Update JUnit from 5.2.0-M1 -> 5.2.0-RC1
  Update xmlunit from 2.5.1 -> 2.6.0
  Update mockito-core from 2.18.0 -> 2.18.3
  Fixieee (#3970)
  Fix IEEE Fetcher by enabling cookie support (#3968)
  Update flowless from 0.6 -> 0.6.1
  Update wiremock from 2.16.0 -> 2.17.0
  Fix ebook.de (#3967)
  LOC test #3854
  Fix arxiv tests
  New translations JabRef_en.properties (French) (#3963)
  Upgrade modernizer plugin
  New Crowdin translations (#3962)
  Fix test
  Improve test
  New Crowdin translations (#3961)
  New translations JabRef_en.properties (French) (#3960)
  Remove brackets before checking equality
  Replace all IEEE URLs with https #3930 (#3944)
  ...

# Conflicts:
#	build.gradle
#	src/main/java/org/jabref/gui/BasePanel.java
#	src/main/java/org/jabref/gui/actions/CleanupAction.java
#	src/main/java/org/jabref/gui/collab/ChangeScanner.java
#	src/main/java/org/jabref/gui/exporter/ExportAction.java
#	src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java
#	src/main/java/org/jabref/gui/openoffice/DetectOpenOfficeInstallation.java
#	src/main/java/org/jabref/gui/openoffice/OpenOfficeSidePanel.java
#	src/main/java/org/jabref/gui/preftabs/PreferencesDialog.java
@stefan-kolb stefan-kolb added this to the v4.3 milestone Apr 26, 2018
@tobiasdiez tobiasdiez removed their assignment Apr 30, 2018
@tobiasdiez
Copy link
Member

MathSciNet works, but I've no longer a subscription to zbMath...

This was referenced Aug 26, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fetcher
Projects
None yet
Milestone
v4.4
Development

No branches or pull requests
3 participants
@LinusDietz @stefan-kolb @tobiasdiez