Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DOI added by ArXiv #6798

Merged
merged 1 commit into from
Aug 27, 2020
Merged

New DOI added by ArXiv #6798

merged 1 commit into from
Aug 27, 2020

Conversation

koppor
Copy link
Member

@koppor koppor commented Aug 27, 2020

This refs #6369,

Does not fully fix, beause:

org.jabref.logic.importer.util.ShortDOIServiceTest

  Test shouldThrowExceptionWhenDOIWasNotFound() FAILED

The other issues are related to keys and offline servers. For new fetcher issues, we should open a new ticket.

Refs #3854

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 27, 2020
@tobiasdiez
Copy link
Member

Tests are failling, but this doesn't seem to be related to this PR.

@tobiasdiez tobiasdiez merged commit f81f619 into master Aug 27, 2020
@tobiasdiez tobiasdiez deleted the fix-fetcher branch August 27, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants